Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 1205023003: Bug fix: toPositionInCoposedTree should treat positions with insertion points (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis, yosin_UTC9
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Bug fix: toPositionInCoposedTree should treat positions with insertion points Now a position is passed to toPositionInCoposedTree and its related node is an insertion point like <content>, this conversion hits an assertion because there should not be any insertion points in the composed tree world. This CL fixes this to avoid to use the insertion point in such case. BUG=504035 TEST=webkit_unit_tests --gtest_filter=PositionTest.* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M Source/core/dom/Position.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/dom/PositionTest.cpp View 1 chunk +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-25 05:50:22 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-25 06:00:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205023003/1
4 years, 10 months ago (2015-06-25 09:01:26 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 09:08:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197804

Powered by Google App Engine
This is Rietveld 408576698