Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1204843003: Add StyledMarkupSerializerTest.AcrossShadow (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add StyledMarkupSerializerTest.AcrossShadow This CL adds an unit layout test selection-across-shadow, which tests that the selection should be serialized across a shadow boundary as if there is no shadow boundary. BUG=275851 TEST=webkit_unit_tests --gtest_filter=StyledMarkupSerializerTest.* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197872

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M Source/core/editing/EditingTestBase.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingTestBase.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializerTest.cpp View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (4 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-24 09:34:37 UTC) #2
hajimehoshi
It seems better for us to wait until crrev.com/1204853003 is landed.
4 years, 10 months ago (2015-06-24 10:17:09 UTC) #3
yosin_UTC9
On 2015/06/24 10:17:09, hajimehoshi wrote: > It seems better for us to wait until crrev.com/1204853003 ...
4 years, 10 months ago (2015-06-25 03:49:48 UTC) #4
hajimehoshi
Rebased. PTAL
4 years, 10 months ago (2015-06-25 04:05:54 UTC) #5
yosin_UTC9
lgtm
4 years, 10 months ago (2015-06-25 05:55:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204843003/40001
4 years, 10 months ago (2015-06-25 09:01:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68258)
4 years, 10 months ago (2015-06-25 12:21:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204843003/40001
4 years, 10 months ago (2015-06-26 00:56:37 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 01:51:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197872

Powered by Google App Engine
This is Rietveld 408576698