Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 1204203002: Bug fix: toPositionInComposedTree should treat positions with shadow roots (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Bug fix: toPositionInComposedTree should treat positions with shadow roots A PositionInComposedTree's anchor should not be a shadow root because there should not be shadow roots in the composed tree world (similar to crrev.com/1205023003). This CL fixes toPositionInComposedTree for a case when a given position's anchor is a shadow root. BUG=n/a TEST=webkit_unit_tests --gtest_filter=PositionTest.* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197815

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M Source/core/dom/Position.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M Source/core/dom/PositionTest.cpp View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-25 09:19:11 UTC) #2
yosin_UTC9
lgtm Thanks!
4 years, 10 months ago (2015-06-25 09:33:06 UTC) #3
tkent
lgtm
4 years, 10 months ago (2015-06-25 09:47:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204203002/20001
4 years, 10 months ago (2015-06-25 10:26:54 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 11:50:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197815

Powered by Google App Engine
This is Rietveld 408576698