Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1204793002: Fix errors in MB when run for the first time on a new builder. (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix errors in MB when run for the first time on a new builder. The first time we run a build on a GN builder, it's possible that MB will run and the build directory (//out/Release) may not exist yet; in that case, we need to create the directory before trying to write the list of runtime_deps that GN will need to read. R=maruel@chromium.org BUG=480053 Committed: https://crrev.com/c3441d156f8beb8cdd76880988132c197ddef2e1 Cr-Commit-Position: refs/heads/master@{#335793}

Patch Set 1 : patch for review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M tools/mb/mb.py View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/mb/mb_unittest.py View 5 chunks +7 lines, -2 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Dirk Pranke
https://codereview.chromium.org/1204793002/diff/20001/tools/mb/mb_unittest.py File tools/mb/mb_unittest.py (right): https://codereview.chromium.org/1204793002/diff/20001/tools/mb/mb_unittest.py#newcode19 tools/mb/mb_unittest.py:19: self.cmds = [] the stuff related to self.cmds and ...
4 years, 10 months ago (2015-06-23 19:54:37 UTC) #2
M-A Ruel
lgtm
4 years, 10 months ago (2015-06-23 20:42:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204793002/20001
4 years, 10 months ago (2015-06-23 20:44:59 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
4 years, 10 months ago (2015-06-23 20:52:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204793002/20001
4 years, 10 months ago (2015-06-23 21:14:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2015-06-23 23:01:47 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 23:02:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3441d156f8beb8cdd76880988132c197ddef2e1
Cr-Commit-Position: refs/heads/master@{#335793}

Powered by Google App Engine
This is Rietveld 408576698