Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1204863002: Fix various windows-isms in the MB gen code paths. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@mb_mkdir
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix various windows-isms in the MB gen code paths. We needed to handle windows-style path separators properly, and handle the fact that binaries have ".exe" in their names. R=maruel@chromium.org BUG=480053 Committed: https://crrev.com/34bd39d5ca100f9417423cedc6d0228af73acd35 Cr-Commit-Position: refs/heads/master@{#335859}

Patch Set 1 #

Patch Set 2 : s/\\/os.sep/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/mb/mb.py View 1 3 chunks +7 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-23 21:10:09 UTC) #1
M-A Ruel
lgtm
5 years, 6 months ago (2015-06-23 21:10:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204863002/1
5 years, 6 months ago (2015-06-23 21:14:26 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/102439)
5 years, 6 months ago (2015-06-23 21:29:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204863002/20001
5 years, 6 months ago (2015-06-24 01:31:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 02:36:59 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 02:38:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34bd39d5ca100f9417423cedc6d0228af73acd35
Cr-Commit-Position: refs/heads/master@{#335859}

Powered by Google App Engine
This is Rietveld 408576698