Issue 12040008: Disaply compile error position in editor

Issue 12040008: Disaply compile error position in editor (Closed)

Created:
7 years, 11 months ago by Peter Rybin

Modified:
7 years, 10 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Disaply compile error position in editor Committed: http://code.google.com/p/chromedevtools/source/detail?r=1134

Patch Set 2 : Diplay compile error in result dialog and navigate in editor #

Patch Set 6 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -25 lines)			Patch
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/LiveEditWizardAction.java	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java	View	1	4 chunks	+26 lines, -5 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java	View	1 2 3 4 5	8 chunks	+105 lines, -10 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PushChangesWizard.java	View	1	5 chunks	+11 lines, -6 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipScriptImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

apavlov

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java File plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java (right): https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java#newcode341 plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java:341: return NLS.bind("{0} ({1}:{2})", new Object[] { //$NON-NLS-1$ Is it ...

7 years, 11 months ago (2013-01-22 06:38:10 UTC) #2

Peter Rybin

7 years, 11 months ago (2013-01-22 16:28:59 UTC) #3

apavlov

LGTM with a nit https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties File plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties (right): https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties#newcode8 plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties:8: LiveEditResultDialog_MOVE_CARET=Select in editor I'd suggest ...

7 years, 11 months ago (2013-01-24 12:57:14 UTC) #4

Peter Rybin

7 years, 10 months ago (2013-01-28 20:49:04 UTC) #5

https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
(right):

https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties:8:
LiveEditResultDialog_MOVE_CARET=Select in editor
On 2013/01/24 12:57:14, apavlov wrote:
> I'd suggest that you fix the message name, too.

Done.

Expand Messages | Collapse Messages