plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java - Issue 12040008: Disaply compile error position in editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java

Issue 12040008: Disaply compile error position in editor (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PushChangesWizard.java ('k') | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java

diff --git a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java

index 880d30146410876c05e8af065dca5dde12e0c528..3ea3d335e5a69e030fc8e9c5cbc1ed969b53e1fa 100644

--- a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java

+++ b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java

@@ -41,6 +41,7 @@ import org.chromium.debug.ui.WizardUtils.WizardFinishController;

import org.chromium.debug.ui.WizardUtils.WizardFinisher;

import org.chromium.debug.ui.WizardUtils.WizardLogic;

import org.chromium.debug.ui.actions.ChooseVmControl;

+import org.chromium.debug.ui.liveedit.LiveEditResultDialog.ErrorPositionHighlighter;

import org.chromium.debug.ui.liveedit.PushChangesWizard.FinisherDelegate;

import org.chromium.sdk.UpdatableScript.ChangeDescription;

@@ -67,7 +68,8 @@ class WizardLogicBuilder {

updater = new Updater();

}

- WizardLogic create(final List<? extends ScriptTargetMapping> targetList) {

+ WizardLogic create(final List<? extends ScriptTargetMapping> targetList,

+ final ErrorPositionHighlighter positionHighlighter) {

Scope scope = updater.rootScope();

final boolean skipSingleTargetSelection = true;

@@ -189,7 +191,7 @@ class WizardLogicBuilder {

createProcessor(handleErrors(new NormalExpression<WizardFinisher>() {

@Calculate

public WizardFinisher calculate(FinisherDelegate finisherDelegate) {

- return new PushChangesWizard.FinisherImpl(finisherDelegate);

+ return new PushChangesWizard.FinisherImpl(finisherDelegate, positionHighlighter);

}

@DependencyGetter

public ValueSource<? extends Optional<? extends FinisherDelegate>>