Android webview fix gpu crashes after destroy

content/browser/renderer_host/surface_texture_transport_client_android.cc

Index: content/browser/renderer_host/surface_texture_transport_client_android.cc
diff --git a/content/browser/renderer_host/surface_texture_transport_client_android.cc b/content/browser/renderer_host/surface_texture_transport_client_android.cc
index 8c2b8d34166603fce761ad12e96f684ff5d4cdae..48d1ec90c9ae7448e1593fb8c11b753c556ea7dd 100644
--- a/content/browser/renderer_host/surface_texture_transport_client_android.cc
+++ b/content/browser/renderer_host/surface_texture_transport_client_android.cc
@@ -51,8 +51,10 @@ scoped_refptr<cc::Layer> SurfaceTextureTransportClient::Initialize() {
 gfx::GLSurfaceHandle
 SurfaceTextureTransportClient::GetCompositingSurface(int surface_id) {
   DCHECK(surface_id);
-  if (!window_)
+  if (!window_) {
     window_ = surface_texture_->CreateSurface();
+    ANativeWindow_acquire(window_);

[no sievers, 2013/01/28 19:46:15]

Now we are leaking this extra ref.
Note that CreateSurface already returns the window with one ref.

Also, we need to handle the other codepath (compositor_impl_android.cc).

Since we already correctly maintain references on the UI thread we only need to
fix the race between UI and GPU thread during surface lookup.

I suggest we just acquire an extra ref on the gpu thread in
GpuSurfaceTracker::GetNativeWidget() where we hold a lock.
(Consider renaming it to AcquireNativeWidget()).

We can release the ref after the call to surface->Initialize(), because having
created a window surface from the ANativeWindow now holds an appropriate ref to
the underlying window.

[boliu, 2013/01/28 20:47:09]

GpuSurfaceTracker is not an android only class. Is there a general abstraction
for gfx::AcceleratedWidget that I can use?

+  }
 
   GpuSurfaceTracker::Get()->SetNativeWidget(surface_id, window_);
   return gfx::GLSurfaceHandle(gfx::kDummyPluginWindow, false);