Android webview fix gpu crashes after destroy

content/browser/renderer_host/surface_texture_transport_client_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/surface_texture_transport_client_android.h"
 
 #include <android/native_window_jni.h>
 
 #include "base/bind.h"
 #include "cc/video_layer.h"
@@ skipping 33 matching lines @@
       base::Bind(
           &SurfaceTextureTransportClient::OnSurfaceTextureFrameAvailable,
           base::Unretained(this)));
   surface_texture_->DetachFromGLContext();
   return video_layer_.get();
 }
 
 gfx::GLSurfaceHandle
 SurfaceTextureTransportClient::GetCompositingSurface(int surface_id) {
   DCHECK(surface_id);
-  if (!window_)
+  if (!window_) {
     window_ = surface_texture_->CreateSurface();
+    ANativeWindow_acquire(window_);

[no sievers, 2013/01/28 19:46:15]

Now we are leaking this extra ref.
Note that CreateSurface already returns the window with one ref.

Also, we need to handle the other codepath (compositor_impl_android.cc).

Since we already correctly maintain references on the UI thread we only need to
fix the race between UI and GPU thread during surface lookup.

I suggest we just acquire an extra ref on the gpu thread in
GpuSurfaceTracker::GetNativeWidget() where we hold a lock.
(Consider renaming it to AcquireNativeWidget()).

We can release the ref after the call to surface->Initialize(), because having
created a window surface from the ANativeWindow now holds an appropriate ref to
the underlying window.

[boliu, 2013/01/28 20:47:09]

GpuSurfaceTracker is not an android only class. Is there a general abstraction
for gfx::AcceleratedWidget that I can use?

+  }
 
   GpuSurfaceTracker::Get()->SetNativeWidget(surface_id, window_);
   return gfx::GLSurfaceHandle(gfx::kDummyPluginWindow, false);
 }
 
 void SurfaceTextureTransportClient::SetSize(const gfx::Size& size) {
   surface_texture_->SetDefaultBufferSize(size.width(), size.height());
   video_layer_->setBounds(size);
   video_frame_ = NULL;
 }
@@ skipping 25 matching lines @@
 
 void SurfaceTextureTransportClient::PutCurrentFrame(
     const scoped_refptr<media::VideoFrame>& frame) {
 }
 
 void SurfaceTextureTransportClient::OnSurfaceTextureFrameAvailable() {
   video_layer_->setNeedsDisplay();
 }
 
 } // namespace content