ui/gl/gl_surface_egl.cc - Issue 12038095: Android webview fix gpu crashes after destroy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_surface_egl.cc

Issue 12038095: Android webview fix gpu crashes after destroy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unneeded changes. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gl/gl_surface_egl.cc

diff --git a/ui/gl/gl_surface_egl.cc b/ui/gl/gl_surface_egl.cc

index 7d216c140f778778a9b6ae3cafb9464b09254190..e9c50b41e121b1c5dc6a03ef18d4f407dbbf2fa6 100644

--- a/ui/gl/gl_surface_egl.cc

+++ b/ui/gl/gl_surface_egl.cc

@@ -224,6 +224,11 @@ NativeViewGLSurfaceEGL::NativeViewGLSurfaceEGL(bool software,

bool NativeViewGLSurfaceEGL::Initialize() {

DCHECK(!surface_);

+ if (!window_) {

no sievers 2013/01/28 20:55:06 if (window_ == kNullAcceleratedWidget)

+ LOG(ERROR) << "Trying to create surface without window.";

+ return false;

+ }

if (!GetDisplay()) {

LOG(ERROR) << "Trying to create surface with invalid display.";

return false;