Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 120343004: Reland r242290, r241609, r242134. (Closed)

Created:
6 years, 12 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
bcwhite, guohui
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, haitaol+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Reland r242290, r241609, r242134. I had reverted them speculatively (in r242297, r242298, r242299) hoping to fix a browser_tests issue on chromeos, but the reverts of these CLs didn't help. BUG=none TBR=guohui@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242333

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+801 lines, -232 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/signin/signin_browsertest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller_unittest.mm View 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.h View 3 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 13 chunks +83 lines, -50 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 10 chunks +13 lines, -62 lines 0 comments Download
M chrome/browser/ui/views/profile_chooser_view.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc View 1 chunk +60 lines, -0 lines 0 comments Download
D chrome/browser/ui/webui/inline_login_ui.h View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/webui/inline_login_ui.cc View 5 chunks +66 lines, -58 lines 0 comments Download
A chrome/browser/ui/webui/signin/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/signin/inline_login_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/signin/inline_login_handler.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/signin/inline_login_handler_impl.h View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +270 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/signin/inline_login_ui.h View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/browser/ui/webui/signin/inline_login_ui.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/profile_management_switches.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Nico
Committed patchset #1 manually as r242333.
6 years, 12 months ago (2013-12-23 00:07:12 UTC) #1
bcwhite
https://codereview.chromium.org/120343004/diff/1/chrome/common/profile_management_switches.cc File chrome/common/profile_management_switches.cc (right): https://codereview.chromium.org/120343004/diff/1/chrome/common/profile_management_switches.cc#newcode12 chrome/common/profile_management_switches.cc:12: bool IsEnableInlineSignin() { This function should have been renamed ...
6 years, 12 months ago (2013-12-23 17:41:47 UTC) #2
Nico
On 2013/12/23 17:41:47, bcwhite wrote: > https://codereview.chromium.org/120343004/diff/1/chrome/common/profile_management_switches.cc > File chrome/common/profile_management_switches.cc (right): > > https://codereview.chromium.org/120343004/diff/1/chrome/common/profile_management_switches.cc#newcode12 > ...
6 years, 12 months ago (2013-12-23 18:39:51 UTC) #3
Randy Smith (Not in Mondays)
6 years, 4 months ago (2014-07-30 14:44:37 UTC) #4
Message was sent while issue was closed. 
On 2013/12/23 18:39:51, Nico (away) wrote:
> On 2013/12/23 17:41:47, bcwhite wrote:
> >
>
https://codereview.chromium.org/120343004/diff/1/chrome/common/profile_manage...
> > File chrome/common/profile_management_switches.cc (right):
> > 
> >
>
https://codereview.chromium.org/120343004/diff/1/chrome/common/profile_manage...
> > chrome/common/profile_management_switches.cc:12: bool IsEnableInlineSignin()
{
> > This function should have been renamed to match the new flag name.
> 
> Please leave comments about this code on the original review for it (which you
> can find by going to crrev.com/rXXXXX and then looking for the "Review URL"
> link). I didn't write this code.

Adding code review links for easy lookup, given that http://crbug.com/398749 may
make people want to get to them:

https://codereview.chromium.org/118343003
https://codereview.chromium.org/116543007
https://codereview.chromium.org/115393004

Powered by Google App Engine
This is Rietveld 408576698