Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 116543007: Add cross account error detection to inline signin (Closed)

Created:
7 years ago by guohui
Modified:
7 years ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -60 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.h View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 11 chunks +83 lines, -44 lines 0 comments Download
M chrome/browser/ui/webui/inline_login_ui.cc View 1 2 chunks +29 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
guohui
Hey, could you please take a look at the CL? Thanks, Hui
7 years ago (2013-12-17 01:02:56 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm The code in StartExplicitSync() is getting really complicated :-)
7 years ago (2013-12-18 16:40:13 UTC) #2
guohui
On 2013/12/18 16:40:13, Roger Tawa wrote: > lgtm > > The code in StartExplicitSync() is ...
7 years ago (2013-12-18 17:04:52 UTC) #3
xiyuan
inline_login_ui.cc LGTM
7 years ago (2013-12-18 17:22:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/116543007/170001
7 years ago (2013-12-18 18:54:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=204601
7 years ago (2013-12-18 19:08:22 UTC) #6
guohui
7 years ago (2013-12-18 19:11:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r241609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698