Turn on inline signin by default

Turn on inline signin by default

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242290

[guohui, 2013-12-17 16:01:48]

Hey,

could you please take a look at the CL?

xiyuan@ for chrome\browser\ui\webui\inline_login_ui.cc,
yoz@ for chrome\browser\extensions\signin\gaia_auth_extension_loader.cc,
rogerta@ for the rest

Thanks!

Hui

[xiyuan, 2013-12-17 16:19:43]

chrome\browser\ui\webui\inline_login_ui.cc LGTM

[Yoyo Zhou, 2013-12-17 17:36:02]

rubber stamp LGTM

[Roger Tawa OOO till Jul 10th, 2013-12-17 20:59:17]

Should create a helper function, maybe like:

   bool signin::IsInlineSigninEnabled();

instead of checking the command line flag explicitly in the 2 or 3 places left. 
This will be helpful to Brian with his finch integration (speak to him about it,
just in case he already wrote a helper function).

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/profile_chooser_view.cc (right):

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/profile_chooser_view.cc:571: ShowView(GAIA_SIGNIN_VIEW,
avatar_menu_.get());
Why take out the else case?

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/inline_login_ui.cc (right):

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/inline_login_ui.cc:170: params.SetString("constrained",
is_constrained);
What is this change for?  Why replace email with this?

[guohui, 2013-12-17 23:00:24]

Brian has a pending CL 108803007 that adds an helper function for inline switch
check. Uploaded a new patch rebased on it.
Also fixed broken tests, and removed some dead code.

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/profile_chooser_view.cc (right):

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/profile_chooser_view.cc:571: ShowView(GAIA_SIGNIN_VIEW,
avatar_menu_.get());
On 2013/12/17 20:59:18, Roger Tawa wrote:
> Why take out the else case?
because the avatar bubble should always use the embedded signin flow.  The else
case pre-dated the inline signin and was there as a temporary workaround.

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/inline_login_ui.cc (right):

https://codereview.chromium.org/115393004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/inline_login_ui.cc:170: params.SetString("constrained",
is_constrained);
On 2013/12/17 20:59:18, Roger Tawa wrote:
> What is this change for?  Why replace email with this?
as discussed offline, i did not replace email, only indentation changes here =)

[Roger Tawa OOO till Jul 10th, 2013-12-18 03:59:34]

lgtm

[guohui, 2013-12-19 15:17:29]

+sky, for owner review of
chrome\browser\ui\bookmarks\bookmark_bubble_sign_in_delegate_unittest.cc
chrome\browser\ui\views\profile_chooser_view.cc
chrome\common\profile_management_switches.cc
chrome\common\profile_management_switches.h

[sky, 2013-12-19 16:53:37]

LGTM

https://codereview.chromium.org/115393004/diff/70001/chrome/common/profile_ma...
File chrome/common/profile_management_switches.h (right):

https://codereview.chromium.org/115393004/diff/70001/chrome/common/profile_ma...
chrome/common/profile_management_switches.h:27: 
nit: remove newline.

[commit-bot: I haz the power, 2013-12-19 19:54:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/115393004/90001

[commit-bot: I haz the power, 2013-12-19 20:19:34]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-19 20:40:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/115393004/110001

[commit-bot: I haz the power, 2013-12-19 21:53:34]

Retried try job too often on mac_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-20 18:26:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/115393004/230001

[commit-bot: I haz the power, 2013-12-20 20:25:55]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-20 20:41:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/115393004/230001

[commit-bot: I haz the power, 2013-12-20 23:58:04]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-21 05:13:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/115393004/230001

[commit-bot: I haz the power, 2013-12-21 07:49:37]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-21 15:39:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/115393004/230001

[commit-bot: I haz the power, 2013-12-21 18:05:08]

Change committed as 242290