Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: cc/resources/resource.h

Issue 1202843008: cc: Fix BytesPerPixel issue and refactor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Android build break. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/raster/tile_task_worker_pool_unittest.cc ('k') | cc/resources/resource_format.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_RESOURCES_RESOURCE_H_ 5 #ifndef CC_RESOURCES_RESOURCE_H_
6 #define CC_RESOURCES_RESOURCE_H_ 6 #define CC_RESOURCES_RESOURCE_H_
7 7
8 #include "base/numerics/safe_math.h"
9 #include "cc/base/cc_export.h" 8 #include "cc/base/cc_export.h"
10 #include "cc/resources/resource_provider.h" 9 #include "cc/resources/resource_provider.h"
10 #include "cc/resources/resource_util.h"
11 #include "ui/gfx/geometry/size.h" 11 #include "ui/gfx/geometry/size.h"
12 12
13 namespace cc { 13 namespace cc {
14 14
15 class CC_EXPORT Resource { 15 class CC_EXPORT Resource {
16 public: 16 public:
17 Resource() : id_(0), format_(RGBA_8888) {} 17 Resource() : id_(0), format_(RGBA_8888) {}
18 Resource(unsigned id, const gfx::Size& size, ResourceFormat format) 18 Resource(unsigned id, const gfx::Size& size, ResourceFormat format)
19 : id_(id), 19 : id_(id),
20 size_(size), 20 size_(size),
21 format_(format) {} 21 format_(format) {}
22 22
23 ResourceId id() const { return id_; } 23 ResourceId id() const { return id_; }
24 gfx::Size size() const { return size_; } 24 gfx::Size size() const { return size_; }
25 ResourceFormat format() const { return format_; } 25 ResourceFormat format() const { return format_; }
26 26
27 // Return true if the call to UncheckedMemorySizeBytes would return a value
28 // that fits in a size_t.
29 static bool VerifySizeInBytes(const gfx::Size& size, ResourceFormat format) {
30 base::CheckedNumeric<size_t> checked_value = BitsPerPixel(format);
31 checked_value *= size.width();
32 checked_value *= size.height();
33 if (!checked_value.IsValid())
34 return false;
35 size_t value = checked_value.ValueOrDie();
36 if ((value % 8) != 0)
37 return false;
38 return true;
39 }
40
41 static size_t CheckedMemorySizeBytes(const gfx::Size& size,
42 ResourceFormat format) {
43 DCHECK(VerifySizeInBytes(size, format));
44 base::CheckedNumeric<size_t> checked_value = BitsPerPixel(format);
45 checked_value *= size.width();
46 checked_value *= size.height();
47 checked_value /= 8;
48 return checked_value.ValueOrDie();
49 }
50
51 inline static size_t UncheckedMemorySizeBytes(const gfx::Size& size,
52 ResourceFormat format) {
53 DCHECK(VerifySizeInBytes(size, format));
54 return static_cast<size_t>(BitsPerPixel(format)) * size.width() *
55 size.height() / 8;
56 }
57
58 protected: 27 protected:
59 void set_id(ResourceId id) { id_ = id; } 28 void set_id(ResourceId id) { id_ = id; }
60 void set_dimensions(const gfx::Size& size, ResourceFormat format) { 29 void set_dimensions(const gfx::Size& size, ResourceFormat format) {
61 size_ = size; 30 size_ = size;
62 format_ = format; 31 format_ = format;
63 } 32 }
64 33
65 private: 34 private:
66 ResourceId id_; 35 ResourceId id_;
67 gfx::Size size_; 36 gfx::Size size_;
68 ResourceFormat format_; 37 ResourceFormat format_;
69 38
70 DISALLOW_COPY_AND_ASSIGN(Resource); 39 DISALLOW_COPY_AND_ASSIGN(Resource);
71 }; 40 };
72 41
73 } // namespace cc 42 } // namespace cc
74 43
75 #endif // CC_RESOURCES_RESOURCE_H_ 44 #endif // CC_RESOURCES_RESOURCE_H_
OLDNEW
« no previous file with comments | « cc/raster/tile_task_worker_pool_unittest.cc ('k') | cc/resources/resource_format.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698