Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2327)

Unified Diff: chrome/common/extensions/extension.cc

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index cf529d85845b5e939a9b61364522dc565b9ee7b5..c744ba5e4ce1a9a83fc7d851a12328eb1d86acc8 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -1922,7 +1922,6 @@ bool Extension::LoadSharedFeatures(
!LoadNaClModules(error) ||
!LoadSandboxedPages(error) ||
!LoadRequirements(error) ||
- !LoadDefaultLocale(error) ||
!LoadOfflineEnabled(error) ||
// LoadBackgroundScripts() must be called before LoadBackgroundPage().
!LoadBackgroundScripts(error) ||
@@ -2268,17 +2267,6 @@ bool Extension::LoadRequirements(string16* error) {
return true;
}
-bool Extension::LoadDefaultLocale(string16* error) {
- if (!manifest_->HasKey(keys::kDefaultLocale))
- return true;
- if (!manifest_->GetString(keys::kDefaultLocale, &default_locale_) ||
- !l10n_util::IsValidLocaleSyntax(default_locale_)) {
- *error = ASCIIToUTF16(errors::kInvalidDefaultLocale);
- return false;
- }
- return true;
-}
-
bool Extension::LoadOfflineEnabled(string16* error) {
// Defaults to false, except for platform apps which are offline by default.
if (!manifest_->HasKey(keys::kOfflineEnabled)) {

Powered by Google App Engine
This is Rietveld 408576698