Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4789)

Unified Diff: chrome/common/extensions/extension.h

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index ae2c9c0392ed758424145c562f06496b2180b676..725aae8baeb11aa2f5392396a3bcc723fa496402 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -672,7 +672,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const extensions::Manifest* manifest() const {
return manifest_.get();
}
- const std::string default_locale() const { return default_locale_; }
bool incognito_split_mode() const { return incognito_split_mode_; }
bool offline_enabled() const { return offline_enabled_; }
const OAuth2Info& oauth2_info() const { return oauth2_info_; }
@@ -814,7 +813,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadSandboxedPages(string16* error);
// Must be called after LoadPlugins().
bool LoadRequirements(string16* error);
- bool LoadDefaultLocale(string16* error);
bool LoadOfflineEnabled(string16* error);
bool LoadBackgroundScripts(string16* error);
bool LoadBackgroundScripts(const std::string& key, string16* error);
@@ -936,9 +934,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// The absolute path to the directory the extension is stored in.
FilePath path_;
- // Default locale for fall back. Can be empty if extension is not localized.
- std::string default_locale_;
-
// If true, a separate process will be used for the extension in incognito
// mode.
bool incognito_split_mode_;

Powered by Google App Engine
This is Rietveld 408576698