Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/common/extensions/extension_file_util.cc

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_file_util.cc
diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc
index 3137fc7418cf6d5e281807797bfcb4ff58f369bd..bfb7e7eb11176e5651f61f7e30f066a0ef89add5 100644
--- a/chrome/common/extensions/extension_file_util.cc
+++ b/chrome/common/extensions/extension_file_util.cc
@@ -20,6 +20,7 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/api/extension_action/action_info.h"
+#include "chrome/common/extensions/api/i18n/default_locale_handler.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_l10n_util.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
@@ -562,7 +563,8 @@ static bool ValidateLocaleInfo(const Extension& extension,
const FilePath path = extension.path().Append(
Extension::kLocaleFolder);
bool path_exists = file_util::PathExists(path);
- std::string default_locale = extension.default_locale();
+ std::string default_locale =
+ extensions::LocaleInfo::GetDefaultLocale(&extension);
// If both default locale and _locales folder are empty, skip verification.
if (default_locale.empty() && !path_exists)

Powered by Google App Engine
This is Rietveld 408576698