Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1201983004: Adds API documentation for SkyGames (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
Reviewers:
Hixie, jackson
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds API documentation, improves the API names, and cleans up code. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e130a78ef72116ca013dcde201c7364b7dad7091

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -74 lines) Patch
M sky/examples/game/lib/game_demo_world.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sky/examples/game/lib/node.dart View 19 chunks +196 lines, -26 lines 1 comment Download
M sky/examples/game/lib/node_with_size.dart View 1 chunk +33 lines, -6 lines 0 comments Download
M sky/examples/game/lib/sprite.dart View 3 chunks +40 lines, -17 lines 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 10 chunks +76 lines, -18 lines 0 comments Download
M sky/examples/game/lib/sprite_widget.dart View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
viktorl
5 years, 6 months ago (2015-06-22 17:02:23 UTC) #2
jackson
I think we usually use two // for comments. Is there a reason you used ...
5 years, 6 months ago (2015-06-22 17:04:43 UTC) #4
viktorl
On 2015/06/22 at 17:04:43, jackson wrote: > I think we usually use two // for ...
5 years, 6 months ago (2015-06-22 17:08:34 UTC) #5
Hixie
lgtm https://codereview.chromium.org/1201983004/diff/1/sky/examples/game/lib/node.dart File sky/examples/game/lib/node.dart (right): https://codereview.chromium.org/1201983004/diff/1/sky/examples/game/lib/node.dart#newcode424 sky/examples/game/lib/node.dart:424: /// applyTransformForPivot(canvas); note that save/transform/restore is expensive (expensive ...
5 years, 6 months ago (2015-06-22 17:08:42 UTC) #6
viktorl
Committed patchset #1 (id:1) manually as e130a78ef72116ca013dcde201c7364b7dad7091 (presubmit successful).
5 years, 6 months ago (2015-06-22 17:13:27 UTC) #7
jackson
5 years, 6 months ago (2015-06-22 17:36:54 UTC) #8
Message was sent while issue was closed.
I did not know that was a thing. thanks!

Powered by Google App Engine
This is Rietveld 408576698