Move internals.dart out of Sky SDK

Move internals.dart out of Sky SDK

This file doesn't belong in the SDK because it is an implementation detail of
the Sky engine. Instead, this CL moves the code for dart:sky.internals into the
snapshot. This CL is a step towards merging dart:sky.internals with dart:sky,
which also resides in the snapshot.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/3d58ea59585d63d013458e4602457754b3fd3670

[eseidel, 2015-06-23 06:24:23]

eseidel@chromium.org changed reviewers:
+ ianh@google.com, mpcomplete@google.com

[eseidel, 2015-06-23 06:24:24]

lgtm

Why is this its own dart: instead of just being part of one of the existing?

https://codereview.chromium.org/1200953007/diff/40001/sky/engine/bindings/BUI...
File sky/engine/bindings/BUILD.gn (right):

https://codereview.chromium.org/1200953007/diff/40001/sky/engine/bindings/BUI...
sky/engine/bindings/BUILD.gn:80: dart_sky_builtin_natives_path =
Why not just make it part of dart:sky?

[abarth-chromium, 2015-06-23 14:43:58]

https://codereview.chromium.org/1200953007/diff/40001/sky/engine/bindings/BUI...
File sky/engine/bindings/BUILD.gn (right):

https://codereview.chromium.org/1200953007/diff/40001/sky/engine/bindings/BUI...
sky/engine/bindings/BUILD.gn:80: dart_sky_builtin_natives_path =
On 2015/06/23 at 06:24:24, eseidel wrote:
> Why not just make it part of dart:sky?

Yes, we should make it part of dart:sky.  In this CL, I've just made it build in
the same way.  The next step is to merge it with dart:sky.

That change isn't trivial, however, because the code that hooks up the C++ code
to dart:sky is in a different layer of the system than the code that hooks up
the C++ code to dart:sky.internals.  However, we'll find a way.

[abarth-chromium, 2015-06-23 14:44:34]

Committed patchset #3 (id:40001) manually as
3d58ea59585d63d013458e4602457754b3fd3670 (presubmit successful).