Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Side by Side Diff: sky/tools/skyanalyzer

Issue 1200953007: Move internals.dart out of Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: _____ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import os 7 import os
8 import re 8 import re
9 import subprocess 9 import subprocess
10 import sys 10 import sys
(...skipping 30 matching lines...) Expand all
41 ] 41 ]
42 42
43 def main(): 43 def main():
44 parser = argparse.ArgumentParser(description='Sky Analyzer') 44 parser = argparse.ArgumentParser(description='Sky Analyzer')
45 parser.add_argument('--congratulate', action="store_true") 45 parser.add_argument('--congratulate', action="store_true")
46 parser.add_argument('build_dir', type=str) 46 parser.add_argument('build_dir', type=str)
47 parser.add_argument('app_path', type=str) 47 parser.add_argument('app_path', type=str)
48 args = parser.parse_args() 48 args = parser.parse_args()
49 build_dir = args.build_dir 49 build_dir = args.build_dir
50 analyzer_path = os.path.join(SRC_ROOT, 'third_party/dart-sdk/dart-sdk/bin/da rtanalyzer') 50 analyzer_path = os.path.join(SRC_ROOT, 'third_party/dart-sdk/dart-sdk/bin/da rtanalyzer')
51 dart_builtin_natives_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/buil tin_natives.dart')
52 dart_mojo_internal_path = os.path.join(SRC_ROOT, 'mojo/public/dart/sdk_ext/i nternal.dart')
53 dart_sky_internals_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/sky_in ternals.dart')
51 dart_sky_path = os.path.join(build_dir, 'gen/sky/bindings/dart_sky.dart') 54 dart_sky_path = os.path.join(build_dir, 'gen/sky/bindings/dart_sky.dart')
52 dart_sky_internals_path = os.path.join(SRC_ROOT, 'sky/sdk/lib/internals.dart ')
53 dart_sky_builtin_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/builtin. dart')
54 packages_root = os.path.join(build_dir, 'gen/dart-pkg/packages') 55 packages_root = os.path.join(build_dir, 'gen/dart-pkg/packages')
55 analyzer_args = [analyzer_path, 56 analyzer_args = [analyzer_path,
57 "--url-mapping=dart:mojo.internal,%s" % dart_mojo_internal_path,
56 "--url-mapping=dart:sky,%s" % dart_sky_path, 58 "--url-mapping=dart:sky,%s" % dart_sky_path,
57 "--url-mapping=dart:sky.internals,%s" % dart_sky_internals_path, 59 "--url-mapping=dart:sky.internals,%s" % dart_sky_internals_path,
58 "--url-mapping=dart:sky_builtin,%s" % dart_sky_builtin_path, 60 "--url-mapping=dart:sky_builtin_natives,%s" % dart_builtin_natives_path,
59 "--package-root", packages_root, 61 "--package-root", packages_root,
60 "--package-warnings", 62 "--package-warnings",
61 args.app_path 63 args.app_path
62 ] 64 ]
63 try: 65 try:
64 subprocess.check_output(analyzer_args, stderr=subprocess.STDOUT) 66 subprocess.check_output(analyzer_args, stderr=subprocess.STDOUT)
65 except subprocess.CalledProcessError as e: 67 except subprocess.CalledProcessError as e:
66 errors = [l for l in e.output.split('\n') 68 errors = [l for l in e.output.split('\n')
67 if not any(p.match(l) for p in _IGNORED_PATTERNS)] 69 if not any(p.match(l) for p in _IGNORED_PATTERNS)]
68 if len(errors) > 0: 70 if len(errors) > 0:
69 for error in errors: 71 for error in errors:
70 print >> sys.stderr, error 72 print >> sys.stderr, error
71 # Propagate analyzer error code. 73 # Propagate analyzer error code.
72 return e.returncode 74 return e.returncode
73 # If we do not have any errors left after filtering, return 0. 75 # If we do not have any errors left after filtering, return 0.
74 if args.congratulate: 76 if args.congratulate:
75 print >> sys.stdout, "No analyzer warnings!" 77 print >> sys.stdout, "No analyzer warnings!"
76 return 0 78 return 0
77 79
78 if __name__ == '__main__': 80 if __name__ == '__main__':
79 sys.exit(main()) 81 sys.exit(main())
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698