Move internals.dart out of Sky SDK

sky/engine/bindings/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//sky/engine/bindings/bindings.gni")
 import("//sky/engine/core/core.gni")
 
 source_set("bindings") {
   sources = [
     "builtin.cc",
@@ skipping 42 matching lines @@
   ]
 }
 
 action("generate_snapshot_bin") {
   deps = [
     "//dart/runtime/bin:gen_snapshot($host_toolchain)",
     ":generate_dart_sky",
   ]
   inputs = [
     "//dart/runtime/tools/create_snapshot_bin.py",
-    "//sky/engine/bindings/builtin.dart",
     "//mojo/public/dart/sdk_ext/internal.dart",
     "//mojo/public/dart/sdk_ext/src/handle_watcher.dart",
     "//mojo/public/dart/sdk_ext/src/natives.dart",
     "//mojo/public/dart/sdk_ext/src/timer_queue.dart",
+    "//sky/engine/bindings/builtin_natives.dart",
+    "//sky/engine/bindings/sky_internals.dart",
     "snapshot.dart",
   ]
   vm_isolate_snapshot = "$target_gen_dir/vm_isolate_snapshot.bin"
   isolate_snapshot = "$target_gen_dir/isolate_snapshot.bin"
   outputs = [
     vm_isolate_snapshot,
     isolate_snapshot,
   ]
 
-  builtin_path = rebase_path("//sky/engine/bindings/builtin.dart")
+  dart_mojo_internal_path =
+      rebase_path("//mojo/public/dart/sdk_ext/internal.dart")
+  dart_sky_builtin_natives_path =

[eseidel, 2015/06/23 06:24:24]

Why not just make it part of dart:sky?

[abarth-chromium, 2015/06/23 14:43:58]

Yes, we should make it part of dart:sky.  In this CL, I've just made it build in
the same way.  The next step is to merge it with dart:sky.

That change isn't trivial, however, because the code that hooks up the C++ code
to dart:sky is in a different layer of the system than the code that hooks up
the C++ code to dart:sky.internals.  However, we'll find a way.

+      rebase_path("//sky/engine/bindings/builtin_natives.dart")
+  dart_sky_internals_path =
+      rebase_path("//sky/engine/bindings/sky_internals.dart")
   dart_sky_path = rebase_path("$bindings_output_dir/dart_sky.dart")
-  internal_path = rebase_path("//mojo/public/dart/sdk_ext/internal.dart")
 
   gen_snapshot_dir =
       get_label_info("//dart/runtime/bin:gen_snapshot($host_toolchain)",
                      "root_out_dir")
   script = "//dart/runtime/tools/create_snapshot_bin.py"
 
   args = [
     "--executable",
     rebase_path("$gen_snapshot_dir/gen_snapshot"),
     "--package_root",
     rebase_path("$root_gen_dir"),
     "--script",
     rebase_path("snapshot.dart"),
     "--vm_output_bin",
     rebase_path(vm_isolate_snapshot, root_build_dir),
     "--output_bin",
     rebase_path(isolate_snapshot, root_build_dir),
     "--target_os",
     target_os,
+    "--url_mapping=dart:mojo.internal,$dart_mojo_internal_path",
     "--url_mapping=dart:sky,$dart_sky_path",
-    "--url_mapping=dart:mojo.internal,$internal_path",
-    "--url_mapping=dart:sky_builtin,$builtin_path",
+    "--url_mapping=dart:sky.internals,$dart_sky_internals_path",
+    "--url_mapping=dart:sky_builtin_natives,$dart_sky_builtin_natives_path",
   ]
 }
 
 action("generate_snapshot_file") {
   deps = [
     ":generate_snapshot_bin",
   ]
   inputs = [
     "//dart/runtime/tools/create_snapshot_file.py",
     "snapshot.cc.tmpl",
@@ skipping 285 matching lines @@
   ]
 
   include_dirs = [
     "..",
     "$root_build_dir",
   ]
 
   sources = get_target_outputs(":compile_idls")
   sources += get_target_outputs(":generate_dart_globals")
 }