[Extensions] Kill off ExtensionMsg_AddMessageToConsole

extensions/browser/suggest_permission_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_SUGGEST_PERMISSION_UTIL_H_
 #define EXTENSIONS_BROWSER_SUGGEST_PERMISSION_UTIL_H_
 
 #include "extensions/common/permissions/api_permission.h"
 
 namespace content {
-class RenderViewHost;
+class WebContents;
 }
 
 namespace extensions {
 
 class Extension;
 
 // Checks that |extension| is not NULL and that it has |permission|. If
 // |extension| is NULL, just returns false. If an extension without |permission|
 // returns false and suggests |permision| in the developer tools console.
 bool IsExtensionWithPermissionOrSuggestInConsole(
     APIPermission::ID permission,
     const Extension* extension,
-    content::RenderViewHost* host);
+    content::WebContents* web_contents);

[not at google - send to devlin, 2015/06/19 23:14:58]

RenderFrameHost would be more appropriate.

[Devlin, 2015/06/19 23:53:52]

But that means that then callers have to remember to pass in the main frame (see
other comment for why).  But we could do it, and it wouldn't be too confusing if
we just call the RFH "main_frame".  Still want it in light of only being able to
call it on the main frame?

[not at google - send to devlin, 2015/06/22 17:54:11]

I do think that passing in render frame is more correct, whether or not this is
the main frame. If devtools chooses to have an odd API and drop logs for
anything other than the main frame then so be it, but internally this method
could do the WebContents::FromRFH(rfh)->GetMainFrame() etc.

These devtools caveats should have quick comments btw.

[Devlin, 2015/06/22 19:52:32]

Changed.

 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_SUGGEST_PERMISSION_UTIL_H_