content/renderer/render_frame_impl.h - Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/extension_api/tts_engine_extension_api.cc ('K') | « content/public/renderer/render_frame.h ('k') | content/renderer/render_frame_impl.cc » ('j') | extensions/browser/extension_function.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 8940e64faf2f4b75cbbebd08fae015e3bfa45dce..76ff43764224851a7b36d480d618c639ce6c4862 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -336,6 +336,8 @@ class CONTENT_EXPORT RenderFrameImpl

const gfx::Range& range) override;

void EnsureMojoBuiltinsAreAvailable(v8::Isolate* isolate,

v8::Local<v8::Context> context) override;

+ void AddMessageToConsole(ConsoleMessageLevel level,

+ const std::string& message) override;

// blink::WebFrameClient implementation:

blink::WebPluginPlaceholder* createPluginPlaceholder(

@@ -639,8 +641,6 @@ class CONTENT_EXPORT RenderFrameImpl

void OnReplace(const base::string16& text);

void OnReplaceMisspelling(const base::string16& text);

void OnCSSInsertRequest(const std::string& css);

- void OnAddMessageToConsole(ConsoleMessageLevel level,

- const std::string& message);

void OnJavaScriptExecuteRequest(const base::string16& javascript,

int id,

bool notify_result);