[Extensions] Kill off ExtensionMsg_AddMessageToConsole

chrome/browser/speech/extension_api/tts_engine_extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/speech/extension_api/tts_engine_extension_api.h"
 
 #include <string>
 
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/speech/extension_api/tts_engine_extension_observer.h"
 #include "chrome/browser/speech/extension_api/tts_extension_api.h"
 #include "chrome/browser/speech/extension_api/tts_extension_api_constants.h"
 #include "chrome/browser/speech/tts_controller.h"
 #include "chrome/common/extensions/api/speech/tts_engine_manifest_handler.h"
 #include "chrome/common/extensions/extension_constants.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
-#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
 #include "content/public/common/console_message_level.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/common/extension.h"
-#include "extensions/common/extension_messages.h"
 #include "extensions/common/extension_set.h"
 #include "net/base/network_change_notifier.h"
 
 using extensions::EventRouter;
 using extensions::Extension;
 using extensions::ExtensionSystem;
 
 namespace constants = tts_extension_api_constants;
 
 namespace tts_engine_events {
@@ skipping 10 matching lines @@
   bool has_onpause = event_router->ExtensionHasEventListener(
       extension_id, tts_engine_events::kOnPause);
   bool has_onresume = event_router->ExtensionHasEventListener(
       extension_id, tts_engine_events::kOnResume);
   if (has_onpause == has_onresume)
     return;
 
   extensions::ExtensionHost* host =
       extensions::ProcessManager::Get(profile)
           ->GetBackgroundHostForExtension(extension_id);
-  host->render_process_host()->Send(new ExtensionMsg_AddMessageToConsole(
-      host->render_view_host()->GetRoutingID(),
+  host->host_contents()->GetMainFrame()->AddMessageToConsole(
       content::CONSOLE_MESSAGE_LEVEL_WARNING,
-      constants::kErrorMissingPauseOrResume));
+      constants::kErrorMissingPauseOrResume);

[not at google - send to devlin, 2015/06/19 23:14:58]

Same here.

[Devlin, 2015/06/22 19:52:32]

This one doesn't even check that the background host exists, so maybe it knows
it does (otherwise there's a crash)?  In either case, same idea about trying to
avoid behavior changes.

 }
 
 }  // namespace
 
 TtsExtensionEngine* TtsExtensionEngine::GetInstance() {
   return Singleton<TtsExtensionEngine>::get();
 }
 
 void TtsExtensionEngine::GetVoices(content::BrowserContext* browser_context,
     std::vector<VoiceData>* out_voices) {
@@ skipping 247 matching lines @@
         utterance_id, TTS_EVENT_PAUSE, char_index, std::string());
   } else if (event_type == constants::kEventTypeResume) {
     controller->OnTtsEvent(
         utterance_id, TTS_EVENT_RESUME, char_index, std::string());
   } else {
     EXTENSION_FUNCTION_VALIDATE(false);
   }
 
   return true;
 }