Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1200113004: win toolchain downloader: Don't omit hidden or system files. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

win toolchain downloader: Don't omit hidden or system files. Hashes for both the 2013 and 2015 toolchain don't change for me locally with this change, looks like there are no hidden or system files in the toolchain. (I tried with the "you are a googler" flow.) No intended behavior change. BUG=495204 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
While writing the CL description I realized I might have to test other flows too. ...
5 years, 6 months ago (2015-06-23 03:01:14 UTC) #2
scottmg
No, that's it. lgtm The failure case is bad though (download, followed by immediate deletion ...
5 years, 6 months ago (2015-06-23 03:59:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200113004/1
5 years, 6 months ago (2015-06-23 19:43:02 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 19:45:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295804

Powered by Google App Engine
This is Rietveld 408576698