win toolchain downloader: Don't omit hidden or system files.

win_toolchain/get_toolchain_if_necessary.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Downloads and unpacks a toolchain for building on Windows. The contents are
 matched by sha1 which will be updated when the toolchain is updated.
 
 Having a toolchain script in depot_tools means that it's not versioned
 directly with the source code. That is, if the toolchain is upgraded, but
@@ skipping 30 matching lines @@
 BASEDIR = os.path.dirname(os.path.abspath(__file__))
 DEPOT_TOOLS_PATH = os.path.join(BASEDIR, '..')
 sys.path.append(DEPOT_TOOLS_PATH)
 try:
   import download_from_google_storage
 except ImportError:
   # Allow use of utility functions in this script from package_from_installed
   # on bare VM that doesn't have a full depot_tools.
   pass
 
-if sys.platform != 'cygwin':
-  import ctypes.wintypes
-  GetFileAttributes = ctypes.windll.kernel32.GetFileAttributesW
-  GetFileAttributes.argtypes = (ctypes.wintypes.LPWSTR,)
-  GetFileAttributes.restype = ctypes.wintypes.DWORD
-  FILE_ATTRIBUTE_HIDDEN = 0x2
-  FILE_ATTRIBUTE_SYSTEM = 0x4
-
-
-def IsHidden(file_path):
-  """Returns whether the given |file_path| has the 'system' or 'hidden'
-  attribute set."""
-  p = GetFileAttributes(file_path)
-  assert p != 0xffffffff
-  return bool(p & (FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM))
-
 
 def GetFileList(root):
   """Gets a normalized list of files under |root|."""
   assert not os.path.isabs(root)
   assert os.path.normpath(root) == root
   file_list = []
   for base, _, files in os.walk(root):
     paths = [os.path.join(base, f) for f in files]
-    file_list.extend(x.lower() for x in paths if not IsHidden(x))
+    file_list.extend(x.lower() for x in paths)
   return sorted(file_list)
 
 
 def MakeTimestampsFileName(root):
   return os.path.join(root, '..', '.timestamps')
 
 
 def CalculateHash(root):
   """Calculates the sha1 of the paths to all files in the given |root| and the
   contents of those files, and returns as a hex string."""
@@ skipping 241 matching lines @@
 
   if options.output_json:
     shutil.copyfile(os.path.join(target_dir, '..', 'data.json'),
                     options.output_json)
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())