Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1198603002: Rename all things "leaky" in SkDevice (Closed)

Created:
5 years, 6 months ago by robertphillips
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -30 lines) Patch
M include/core/SkDevice.h View 2 chunks +3 lines, -9 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkDevice.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkDraw.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
5 years, 6 months ago (2015-06-19 20:36:37 UTC) #2
reed1
lgtm
5 years, 6 months ago (2015-06-19 20:57:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198603002/1
5 years, 6 months ago (2015-06-19 21:02:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-19 21:08:22 UTC) #7
bungeman-skia
lgtm
5 years, 6 months ago (2015-06-19 21:13:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198603002/1
5 years, 6 months ago (2015-06-19 21:14:11 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 21:14:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7b05ff11ebc51f3f3abd1c1756337a04f563537e

Powered by Google App Engine
This is Rietveld 408576698