Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: chrome/browser/power/process_power_collector_unittest.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/power/process_power_collector_unittest.cc
diff --git a/chrome/browser/power/process_power_collector_unittest.cc b/chrome/browser/power/process_power_collector_unittest.cc
index 063088ab243dc7edf4e4509dc90d842b7a9bb984..865612f602d16ea23b4e26f0968a55640e263731 100644
--- a/chrome/browser/power/process_power_collector_unittest.cc
+++ b/chrome/browser/power/process_power_collector_unittest.cc
@@ -123,10 +123,10 @@ TEST_F(BrowserProcessPowerTest, MultipleSites) {
GURL url1("http://www.google.com");
GURL url2("http://www.example.com");
GURL url3("https://www.google.com");
- scoped_ptr<Browser> browser2(
- chrome::CreateBrowserWithTestWindowForParams(&native_params));
- scoped_ptr<Browser> browser3(
- chrome::CreateBrowserWithTestWindowForParams(&native_params));
+ scoped_ptr<Browser> browser2 =
msw 2015/07/09 22:37:37 nit: All these callsites in the CL can still use t
xdai1 2015/07/09 23:45:40 Reverted it back....
+ chrome::CreateBrowserWithTestWindowForParams(&native_params);
+ scoped_ptr<Browser> browser3 =
+ chrome::CreateBrowserWithTestWindowForParams(&native_params);
AddTab(browser(), url1);
AddTab(browser2.get(), url2);
AddTab(browser3.get(), url3);
@@ -169,8 +169,8 @@ TEST_F(BrowserProcessPowerTest, MultipleSites) {
TEST_F(BrowserProcessPowerTest, IncognitoDoesntRecordPowerUsage) {
Browser::CreateParams native_params(profile()->GetOffTheRecordProfile(),
chrome::HOST_DESKTOP_TYPE_NATIVE);
- scoped_ptr<Browser> incognito_browser(
- chrome::CreateBrowserWithTestWindowForParams(&native_params));
+ scoped_ptr<Browser> incognito_browser =
+ chrome::CreateBrowserWithTestWindowForParams(&native_params);
GURL url("http://www.google.com");
AddTab(browser(), url);

Powered by Google App Engine
This is Rietveld 408576698