Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2194)

Unified Diff: chrome/browser/profiles/profile_manager_unittest.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager_unittest.cc
diff --git a/chrome/browser/profiles/profile_manager_unittest.cc b/chrome/browser/profiles/profile_manager_unittest.cc
index 78e3273a37579eb6096ae28fe4cb7b6bd18c3ec7..6b85f20efb05ce344ad64eff5cf99bf0f0d9c9dc 100644
--- a/chrome/browser/profiles/profile_manager_unittest.cc
+++ b/chrome/browser/profiles/profile_manager_unittest.cc
@@ -623,8 +623,8 @@ TEST_F(ProfileManagerTest, LastOpenedProfiles) {
// Create a browser for profile1.
Browser::CreateParams profile1_params(profile1, chrome::GetActiveDesktop());
- scoped_ptr<Browser> browser1a(
- chrome::CreateBrowserWithTestWindowForParams(&profile1_params));
+ scoped_ptr<Browser> browser1a =
+ chrome::CreateBrowserWithTestWindowForParams(&profile1_params);
last_opened_profiles = profile_manager->GetLastOpenedProfiles();
ASSERT_EQ(1U, last_opened_profiles.size());
@@ -632,8 +632,8 @@ TEST_F(ProfileManagerTest, LastOpenedProfiles) {
// And for profile2.
Browser::CreateParams profile2_params(profile2, chrome::GetActiveDesktop());
- scoped_ptr<Browser> browser2(
- chrome::CreateBrowserWithTestWindowForParams(&profile2_params));
+ scoped_ptr<Browser> browser2 =
+ chrome::CreateBrowserWithTestWindowForParams(&profile2_params);
last_opened_profiles = profile_manager->GetLastOpenedProfiles();
ASSERT_EQ(2U, last_opened_profiles.size());
@@ -641,8 +641,8 @@ TEST_F(ProfileManagerTest, LastOpenedProfiles) {
EXPECT_EQ(profile2, last_opened_profiles[1]);
// Adding more browsers doesn't change anything.
- scoped_ptr<Browser> browser1b(
- chrome::CreateBrowserWithTestWindowForParams(&profile1_params));
+ scoped_ptr<Browser> browser1b =
+ chrome::CreateBrowserWithTestWindowForParams(&profile1_params);
last_opened_profiles = profile_manager->GetLastOpenedProfiles();
ASSERT_EQ(2U, last_opened_profiles.size());
EXPECT_EQ(profile1, last_opened_profiles[0]);

Powered by Google App Engine
This is Rietveld 408576698