Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/power/process_power_collector_unittest.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/power/process_power_collector.h" 5 #include "chrome/browser/power/process_power_collector.h"
6 6
7 #include "chrome/browser/apps/scoped_keep_alive.h" 7 #include "chrome/browser/apps/scoped_keep_alive.h"
8 #include "chrome/browser/profiles/profile_manager.h" 8 #include "chrome/browser/profiles/profile_manager.h"
9 #include "chrome/browser/ui/apps/chrome_app_delegate.h" 9 #include "chrome/browser/ui/apps/chrome_app_delegate.h"
10 #include "chrome/browser/ui/browser_commands.h" 10 #include "chrome/browser/ui/browser_commands.h"
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 EXPECT_DOUBLE_EQ(5, collector->UpdatePowerConsumptionForTesting()); 116 EXPECT_DOUBLE_EQ(5, collector->UpdatePowerConsumptionForTesting());
117 EXPECT_EQ(100, origin_power_map->GetPowerForOrigin(url)); 117 EXPECT_EQ(100, origin_power_map->GetPowerForOrigin(url));
118 } 118 }
119 119
120 TEST_F(BrowserProcessPowerTest, MultipleSites) { 120 TEST_F(BrowserProcessPowerTest, MultipleSites) {
121 Browser::CreateParams native_params(profile(), 121 Browser::CreateParams native_params(profile(),
122 chrome::HOST_DESKTOP_TYPE_NATIVE); 122 chrome::HOST_DESKTOP_TYPE_NATIVE);
123 GURL url1("http://www.google.com"); 123 GURL url1("http://www.google.com");
124 GURL url2("http://www.example.com"); 124 GURL url2("http://www.example.com");
125 GURL url3("https://www.google.com"); 125 GURL url3("https://www.google.com");
126 scoped_ptr<Browser> browser2( 126 scoped_ptr<Browser> browser2 =
msw 2015/07/09 22:37:37 nit: All these callsites in the CL can still use t
xdai1 2015/07/09 23:45:40 Reverted it back....
127 chrome::CreateBrowserWithTestWindowForParams(&native_params)); 127 chrome::CreateBrowserWithTestWindowForParams(&native_params);
128 scoped_ptr<Browser> browser3( 128 scoped_ptr<Browser> browser3 =
129 chrome::CreateBrowserWithTestWindowForParams(&native_params)); 129 chrome::CreateBrowserWithTestWindowForParams(&native_params);
130 AddTab(browser(), url1); 130 AddTab(browser(), url1);
131 AddTab(browser2.get(), url2); 131 AddTab(browser2.get(), url2);
132 AddTab(browser3.get(), url3); 132 AddTab(browser3.get(), url3);
133 133
134 // Create fake process numbers. 134 // Create fake process numbers.
135 GetProcess(browser())->SetProcessHandle(MakeProcessHandle(1).Pass()); 135 GetProcess(browser())->SetProcessHandle(MakeProcessHandle(1).Pass());
136 GetProcess(browser2.get())->SetProcessHandle(MakeProcessHandle(2).Pass()); 136 GetProcess(browser2.get())->SetProcessHandle(MakeProcessHandle(2).Pass());
137 GetProcess(browser3.get())->SetProcessHandle(MakeProcessHandle(3).Pass()); 137 GetProcess(browser3.get())->SetProcessHandle(MakeProcessHandle(3).Pass());
138 138
139 collector->UpdatePowerConsumptionForTesting(); 139 collector->UpdatePowerConsumptionForTesting();
(...skipping 22 matching lines...) Expand all
162 chrome::CloseTab(browser2.get()); 162 chrome::CloseTab(browser2.get());
163 chrome::CloseTab(browser3.get()); 163 chrome::CloseTab(browser3.get());
164 164
165 collector->UpdatePowerConsumptionForTesting(); 165 collector->UpdatePowerConsumptionForTesting();
166 EXPECT_EQ(1u, metrics_map->size()); 166 EXPECT_EQ(1u, metrics_map->size());
167 } 167 }
168 168
169 TEST_F(BrowserProcessPowerTest, IncognitoDoesntRecordPowerUsage) { 169 TEST_F(BrowserProcessPowerTest, IncognitoDoesntRecordPowerUsage) {
170 Browser::CreateParams native_params(profile()->GetOffTheRecordProfile(), 170 Browser::CreateParams native_params(profile()->GetOffTheRecordProfile(),
171 chrome::HOST_DESKTOP_TYPE_NATIVE); 171 chrome::HOST_DESKTOP_TYPE_NATIVE);
172 scoped_ptr<Browser> incognito_browser( 172 scoped_ptr<Browser> incognito_browser =
173 chrome::CreateBrowserWithTestWindowForParams(&native_params)); 173 chrome::CreateBrowserWithTestWindowForParams(&native_params);
174 GURL url("http://www.google.com"); 174 GURL url("http://www.google.com");
175 AddTab(browser(), url); 175 AddTab(browser(), url);
176 176
177 GURL hidden_url("http://foo.com"); 177 GURL hidden_url("http://foo.com");
178 AddTab(incognito_browser.get(), hidden_url); 178 AddTab(incognito_browser.get(), hidden_url);
179 179
180 // Create fake process numbers. 180 // Create fake process numbers.
181 GetProcess(browser())->SetProcessHandle(MakeProcessHandle(1).Pass()); 181 GetProcess(browser())->SetProcessHandle(MakeProcessHandle(1).Pass());
182 GetProcess(incognito_browser.get()) 182 GetProcess(incognito_browser.get())
183 ->SetProcessHandle(MakeProcessHandle(2).Pass()); 183 ->SetProcessHandle(MakeProcessHandle(2).Pass());
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 base::Bind(&BrowserProcessPowerTest::ReturnCpuAsConstant, 288 base::Bind(&BrowserProcessPowerTest::ReturnCpuAsConstant,
289 base::Unretained(this), 289 base::Unretained(this),
290 5)); 290 5));
291 collector->UpdatePowerConsumptionForTesting(); 291 collector->UpdatePowerConsumptionForTesting();
292 EXPECT_EQ(1u, collector->metrics_map_for_testing()->size()); 292 EXPECT_EQ(1u, collector->metrics_map_for_testing()->size());
293 293
294 window->OnNativeClose(); 294 window->OnNativeClose();
295 collector->UpdatePowerConsumptionForTesting(); 295 collector->UpdatePowerConsumptionForTesting();
296 EXPECT_EQ(0u, collector->metrics_map_for_testing()->size()); 296 EXPECT_EQ(0u, collector->metrics_map_for_testing()->size());
297 } 297 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698