pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

index 58ad5bd8f634c6c66846aec8214d90cb4ade494b..115ec4fef9eeb1c0b53c6eb916aa9a59f471ea3e 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

@@ -133,7 +133,8 @@ jsAst.Statement buildSetupProgram(Program program, Compiler compiler,

'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),

'hasRetainedMetadata': backend.hasRetainedMetadata,

'types': typesAccess,

- 'objectClassName': js.string(namer.runtimeTypeName(compiler.objectClass)),

+ 'objectClassName': js.quoteName(

+ namer.runtimeTypeName(compiler.objectClass)),

'needsStructuredMemberInfo': emitter.needsStructuredMemberInfo,

'usesMangledNames':

compiler.mirrorsLibrary != null || compiler.enabledFunctionApply,

@@ -577,7 +578,7 @@ function $setupProgramName(programData, typesOffset) {

}

// ${ClassBuilder.fieldEncodingDescription}.

var s = fields.split(";");

- fields = s[1] == "" ? [] : s[1].split(",");

+ fields = s[1] ? s[1].split(",") : [];

supr = s[0];

// ${ClassBuilder.functionTypeEncodingDescription}.

split = supr.split(":");