dart2js: Use an abstract Name class for names in the generated JavaScript ast.

pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 // TODO(ahe): Share these with js_helper.dart.
 const FUNCTION_INDEX = 0;
 const NAME_INDEX = 1;
 const CALL_NAME_INDEX = 2;
@@ skipping 115 matching lines @@
      'precompiled': precompiledAccess,
      'finishedClassesAccess': finishedClassesAccess,
      'needsMixinSupport': emitter.needsMixinSupport,
      'needsNativeSupport': program.needsNativeSupport,
      'isInterceptorClass': namer.operatorIs(backend.jsInterceptorClass),
      'isObject' : namer.operatorIs(compiler.objectClass),
      'specProperty': js.string(namer.nativeSpecProperty),
      'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),
      'hasRetainedMetadata': backend.hasRetainedMetadata,
      'types': typesAccess,
-     'objectClassName': js.string(namer.runtimeTypeName(compiler.objectClass)),
+     'objectClassName': js.quoteName(
+         namer.runtimeTypeName(compiler.objectClass)),
      'needsStructuredMemberInfo': emitter.needsStructuredMemberInfo,
      'usesMangledNames':
           compiler.mirrorsLibrary != null || compiler.enabledFunctionApply,
      'tearOffCode': buildTearOffCode(backend),
      'nativeInfoHandler': nativeInfoHandler,
      'operatorIsPrefix' : js.string(namer.operatorIsPrefix),
      'deferredActionString': js.string(namer.deferredAction)};
 
    String skeleton = '''
 function $setupProgramName(programData, typesOffset) {
@@ skipping 423 matching lines @@
       var classData = descriptor["${namer.classDescriptorProperty}"],
           split, supr, fields = classData;
 
       if (#hasRetainedMetadata)
         if (typeof classData == "object" &&
             classData instanceof Array) {
           classData = fields = classData[0];
         }
       // ${ClassBuilder.fieldEncodingDescription}.
       var s = fields.split(";");
-      fields = s[1] == "" ? [] : s[1].split(",");
+      fields = s[1] ? s[1].split(",") : [];
       supr = s[0];
       // ${ClassBuilder.functionTypeEncodingDescription}.
       split = supr.split(":");
       if (split.length == 2) {
         supr = split[0];
         var functionSignature = split[1];
         if (functionSignature)
           descriptor.${namer.operatorSignature} = function(s) {
             return function() {
               return #types[s];
@@ skipping 254 matching lines @@
 (function() {
   var result = $array[$index];
   if ($check) {
     throw new Error(
         name + ": expected value of type \'$type\' at index " + ($index) +
         " but got " + (typeof result));
   }
   return result;
 })()''';
 }