Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
diff --git a/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
index 6414d8091a5d13e2b60043719e4abb9d512a3a15..cfd2bf4cd7a7f4d3bd04a1053a3504915955d867 100644
--- a/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
+++ b/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
@@ -125,7 +125,7 @@ class ParameterStubGenerator {
} else if (member.isInstanceMember) {
if (needsSuperGetter(member)) {
ClassElement superClass = member.enclosingClass;
- String methodName = namer.instanceMethodName(member);
+ jsAst.Name methodName = namer.instanceMethodName(member);
// When redirecting, we must ensure that we don't end up in a subclass.
// We thus can't just invoke `this.foo$1.call(filledInArguments)`.
// Instead we need to call the statically resolved target.
@@ -148,8 +148,8 @@ class ParameterStubGenerator {
jsAst.Fun function = js('function(#) { #; }', [parametersBuffer, body]);
- String name = namer.invocationName(selector);
- String callName =
+ jsAst.Name name = namer.invocationName(selector);
+ jsAst.Name callName =
(callSelector != null) ? namer.invocationName(callSelector) : null;
return new ParameterStubMethod(name, callName, function);
}

Powered by Google App Engine
This is Rietveld 408576698