Subzero: Reduce the amount of #ifdef'd code.

src/IceAssemblerX8632.h

Index: src/IceAssemblerX8632.h
diff --git a/src/IceAssemblerX8632.h b/src/IceAssemblerX8632.h
index 48a5f0a2f6e8c7f56e158ebe33df30c7efec2eb0..782cab6b01218c10f9aec060bebf7d15fab8366e 100644
--- a/src/IceAssemblerX8632.h
+++ b/src/IceAssemblerX8632.h
@@ -252,11 +252,11 @@ class Label {
 
 public:
   Label() {
-#ifndef NDEBUG
-    for (int i = 0; i < kMaxUnresolvedBranches; i++) {
-      unresolved_near_positions_[i] = -1;
+    if (buildAllowsAsserts()) {
+      for (int i = 0; i < kMaxUnresolvedBranches; i++) {

[John, 2015/06/23 22:28:30]

optional: s/i/I/

[Jim Stichnoth, 2015/06/24 21:27:27]

Even LLVM violates its own written rules in cases like this.  (git grep -w i --
*.cpp)

The exception pattern seems to be that single-character integral loop index
variables are often lowercase, while e.g. uppercase I is more commonly used for
complex iterators, or Instruction objection.

It's really hard to bring myself to use "int I"...

+        unresolved_near_positions_[i] = -1;
+      }
     }
-#endif // !NDEBUG
   }
 
   ~Label() = default;