Subzero: Reduce the amount of #ifdef'd code.

src/IceAssemblerX8632.h

 //===- subzero/src/assembler_ia32.h - Assembler for x86-32 ------*- C++ -*-===//
 //
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
@@ skipping 234 matching lines @@
 private:
   Address() = default; // Needed by Address::Absolute.
 };
 
 class Label {
   Label(const Label &) = delete;
   Label &operator=(const Label &) = delete;
 
 public:
   Label() {
-#ifndef NDEBUG
-    for (int i = 0; i < kMaxUnresolvedBranches; i++) {
-      unresolved_near_positions_[i] = -1;
+    if (buildAllowsAsserts()) {
+      for (int i = 0; i < kMaxUnresolvedBranches; i++) {

[John, 2015/06/23 22:28:30]

optional: s/i/I/

[Jim Stichnoth, 2015/06/24 21:27:27]

Even LLVM violates its own written rules in cases like this.  (git grep -w i --
*.cpp)

The exception pattern seems to be that single-character integral loop index
variables are often lowercase, while e.g. uppercase I is more commonly used for
complex iterators, or Instruction objection.

It's really hard to bring myself to use "int I"...

+        unresolved_near_positions_[i] = -1;
+      }
     }
-#endif // !NDEBUG
   }
 
   ~Label() = default;
 
   void FinalCheck() const {
     // Assert if label is being destroyed with unresolved branches pending.
     assert(!IsLinked());
     assert(!HasNear());
   }
 
@@ skipping 645 matching lines @@
 inline void AssemblerX8632::emitFixup(AssemblerFixup *fixup) {
   Buffer.emitFixup(fixup);
 }
 
 inline void AssemblerX8632::emitOperandSizeOverride() { emitUint8(0x66); }
 
 } // end of namespace X8632
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEASSEMBLERX8632_H