Subzero: Reduce the amount of #ifdef'd code.

src/IceAssemblerX8632.cpp

Index: src/IceAssemblerX8632.cpp
diff --git a/src/IceAssemblerX8632.cpp b/src/IceAssemblerX8632.cpp
index ecb6c5b794093de758509d0dcd329717ae59473b..933436d6ebf3b399711f16fccd78ad5aa4ed498a 100644
--- a/src/IceAssemblerX8632.cpp
+++ b/src/IceAssemblerX8632.cpp
@@ -32,14 +32,14 @@ Address Address::ofConstPool(Assembler *Asm, const Constant *Imm) {
 }
 
 AssemblerX8632::~AssemblerX8632() {
-#ifndef NDEBUG
-  for (const Label *Label : CfgNodeLabels) {
-    Label->FinalCheck();
-  }
-  for (const Label *Label : LocalLabels) {
-    Label->FinalCheck();
+  if (buildAllowsAsserts()) {
+    for (const Label *Label : CfgNodeLabels) {

[John, 2015/06/23 22:28:30]

optional: perhaps a good case for auto?

+      Label->FinalCheck();
+    }
+    for (const Label *Label : LocalLabels) {
+      Label->FinalCheck();
+    }
   }
-#endif
 }
 
 void AssemblerX8632::alignFunction() {