Subzero: Reduce the amount of #ifdef'd code.

src/IceAssemblerX8632.cpp

 //===- subzero/src/IceAssemblerX8632.cpp - Assembler for x86-32  ----------===//
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
 //                        The Subzero Code Generator
@@ skipping 14 matching lines @@
 namespace Ice {
 namespace X8632 {
 
 Address Address::ofConstPool(Assembler *Asm, const Constant *Imm) {
   AssemblerFixup *Fixup = Asm->createFixup(llvm::ELF::R_386_32, Imm);
   const RelocOffsetT Offset = 0;
   return Address::Absolute(Offset, Fixup);
 }
 
 AssemblerX8632::~AssemblerX8632() {
-#ifndef NDEBUG
-  for (const Label *Label : CfgNodeLabels) {
-    Label->FinalCheck();
+  if (buildAllowsAsserts()) {
+    for (const Label *Label : CfgNodeLabels) {

[John, 2015/06/23 22:28:30]

optional: perhaps a good case for auto?

+      Label->FinalCheck();
+    }
+    for (const Label *Label : LocalLabels) {
+      Label->FinalCheck();
+    }
   }
-  for (const Label *Label : LocalLabels) {
-    Label->FinalCheck();
-  }
-#endif
 }
 
 void AssemblerX8632::alignFunction() {
   SizeT Align = 1 << getBundleAlignLog2Bytes();
   SizeT BytesNeeded = Utils::OffsetToAlignment(Buffer.getPosition(), Align);
   const SizeT HltSize = 1;
   while (BytesNeeded > 0) {
     hlt();
     BytesNeeded -= HltSize;
   }
@@ skipping 2495 matching lines @@
   assert(shifter == RegX8632::Encoded_Reg_ecx);
   (void)shifter;
   if (Ty == IceType_i16)
     emitOperandSizeOverride();
   emitUint8(isByteSizedArithType(Ty) ? 0xD2 : 0xD3);
   emitOperand(rm, operand);
 }
 
 } // end of namespace X8632
 } // end of namespace Ice