Collecting statistics on iframe permissions use.

chrome/browser/content_settings/permission_context_uma_util.h

Index: chrome/browser/content_settings/permission_context_uma_util.h
diff --git a/chrome/browser/content_settings/permission_context_uma_util.h b/chrome/browser/content_settings/permission_context_uma_util.h
index 8d769aeb2268f5192a963f2b755a0bd522c625a8..38e89df0be8dcbd1ceee14b00d8100697d9a5981 100644
--- a/chrome/browser/content_settings/permission_context_uma_util.h
+++ b/chrome/browser/content_settings/permission_context_uma_util.h
@@ -6,6 +6,7 @@
 #define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_
 
 #include "base/logging.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"

[mlamouri (slow - plz ping), 2015/06/29 14:23:07]

nit: forward declare.

[keenanb, 2015/06/29 19:09:00]

Done.

 #include "components/content_settings/core/common/content_settings_types.h"
 
 class GURL;
@@ -14,14 +15,17 @@ class GURL;
 // operations.
 class PermissionContextUmaUtil {
  public:
+  static void PermissionRequested(
+      ContentSettingsType permission,
+      HostContentSettingsMap* host_content_settings_map,

[mlamouri (slow - plz ping), 2015/06/29 14:23:07]

nit: I think it would be better to have this as the fourth argument to keep
consistency between the methods. Also, maybe you could keep it in the same
position in the file?

[keenanb, 2015/06/29 19:09:00]

i moved the declaration because originally there was no particular ordering, not
alphabetical or logical. and more importantly, originally the orderings in *.cc
and *.h were inconsistent.

this way, the ordering is consistent and logical.

+      const GURL& requesting_origin,
+      const GURL& embedding_origin);
   static void PermissionGranted(ContentSettingsType permission,
                                 const GURL& requesting_origin);
   static void PermissionDenied(ContentSettingsType permission,
                                const GURL& requesting_origin);
   static void PermissionDismissed(ContentSettingsType permission,
                                   const GURL& requesting_origin);
-  static void PermissionRequested(ContentSettingsType permission,
-                                  const GURL& requesting_origin);
   static void PermissionIgnored(ContentSettingsType permission,
                                 const GURL& requesting_origin);