chrome/browser/content_settings/permission_context_base.cc - Issue 1197853005: Collecting statistics on iframe permissions use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_context_base.cc

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made suggested fixes and changed logging details. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/content_settings/permission_context_base.cc

diff --git a/chrome/browser/content_settings/permission_context_base.cc b/chrome/browser/content_settings/permission_context_base.cc

index 32b9badf89461151e20c589c63c51225012bf382..487042c8b38e5a9fee3c96624ce01b08ea2335d3 100644

--- a/chrome/browser/content_settings/permission_context_base.cc

+++ b/chrome/browser/content_settings/permission_context_base.cc

@@ -131,7 +131,8 @@ void PermissionContextBase::DecidePermission(

}

PermissionContextUmaUtil::PermissionRequested(

- permission_type_, requesting_origin);

+ permission_type_, profile_->GetHostContentSettingsMap(),

+ requesting_origin, embedding_origin);

if (PermissionBubbleManager::Enabled()) {

PermissionBubbleManager* bubble_manager =