Collecting statistics on iframe permissions use.

chrome/browser/content_settings/permission_context_uma_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_
 
 #include "base/logging.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"

[mlamouri (slow - plz ping), 2015/06/29 14:23:07]

nit: forward declare.

[keenanb, 2015/06/29 19:09:00]

Done.

 #include "components/content_settings/core/common/content_settings_types.h"
 
 class GURL;
 
 // Provides a convenient way of logging UMA for permission related
 // operations.
 class PermissionContextUmaUtil {
  public:
+  static void PermissionRequested(
+      ContentSettingsType permission,
+      HostContentSettingsMap* host_content_settings_map,

[mlamouri (slow - plz ping), 2015/06/29 14:23:07]

nit: I think it would be better to have this as the fourth argument to keep
consistency between the methods. Also, maybe you could keep it in the same
position in the file?

[keenanb, 2015/06/29 19:09:00]

i moved the declaration because originally there was no particular ordering, not
alphabetical or logical. and more importantly, originally the orderings in *.cc
and *.h were inconsistent.

this way, the ordering is consistent and logical.

+      const GURL& requesting_origin,
+      const GURL& embedding_origin);
   static void PermissionGranted(ContentSettingsType permission,
                                 const GURL& requesting_origin);
   static void PermissionDenied(ContentSettingsType permission,
                                const GURL& requesting_origin);
   static void PermissionDismissed(ContentSettingsType permission,
                                   const GURL& requesting_origin);
-  static void PermissionRequested(ContentSettingsType permission,
-                                  const GURL& requesting_origin);
   static void PermissionIgnored(ContentSettingsType permission,
                                 const GURL& requesting_origin);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionContextUmaUtil);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_