Collecting statistics on iframe permissions use.

content/child/permissions/permission_dispatcher.cc

Index: content/child/permissions/permission_dispatcher.cc
diff --git a/content/child/permissions/permission_dispatcher.cc b/content/child/permissions/permission_dispatcher.cc
index eb5ac4538f0f9caf86adea7769ed9ab016e18e7b..f21a227e4f2d3bc760f7897b7781bceee158259e 100644
--- a/content/child/permissions/permission_dispatcher.cc
+++ b/content/child/permissions/permission_dispatcher.cc
@@ -56,6 +56,9 @@ blink::WebPermissionStatus GetWebPermissionStatus(PermissionStatus status) {
       return blink::WebPermissionStatusDenied;
     case PERMISSION_STATUS_ASK:
       return blink::WebPermissionStatusPrompt;
+    case PERMISSION_STATUS_NUM:
+      // PERMISSION_STATUS_NUM should never be passed into this function.

[jww, 2015/07/07 21:14:23]

It appears you didn't add a NOTREACHED into the switch() statement.

Additionally, please remove the comment here in the background_sync_provider;
this is self evident. What I would like to see is a comment in the header file
or at least before the function definition specifying what values the
PermissionStatus arguments can take (namely, it cannot be
PERMISSION_STATUS_NUM). The idea is that this is the API developers will use,
and it should be clear when they look at the definition what they can and cannot
put in as a value.

[keenanb, 2015/07/08 00:37:21]

sort of done. (this function is local to this file.)

+      break;
   }
 
   NOTREACHED();