Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1611)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/child/background_sync/background_sync_provider.cc

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed NOTREACHED calls. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/content_settings/permission_context_uma_util.cc ('k') | content/child/permissions/permission_dispatcher.cc » ('j') | content/child/permissions/permission_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/background_sync/background_sync_provider.cc
diff --git a/content/child/background_sync/background_sync_provider.cc b/content/child/background_sync/background_sync_provider.cc
index 2bee9bbac361ceea9b6c30279569e517d01c6b3d..8704995e79ebbb9736e10a92beae3cbd1c073df6 100644
--- a/content/child/background_sync/background_sync_provider.cc
+++ b/content/child/background_sync/background_sync_provider.cc
@@ -274,6 +274,10 @@ void BackgroundSyncProvider::GetPermissionStatusCallback(
callbacks->onSuccess(new blink::WebSyncPermissionStatus(
blink::WebSyncPermissionStatusPrompt));
break;
+ case PERMISSION_STATUS_NUM:
+ // PERMISSION_STATUS_NUM should never be passed into this function.
jww 2015/07/07 21:14:23 See my comment about this comment in permission_di
keenanb 2015/07/08 00:37:21 Done.
+ NOTREACHED();
+ break;
}
break;
case BACKGROUND_SYNC_ERROR_NOT_FOUND:
« no previous file with comments | « chrome/browser/content_settings/permission_context_uma_util.cc ('k') | content/child/permissions/permission_dispatcher.cc » ('j') | content/child/permissions/permission_dispatcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698