content/public/common/permission_status.mojom - Issue 1197853005: Collecting statistics on iframe permissions use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/permission_status.mojom

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed NOTREACHED calls. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/permission_status.mojom

diff --git a/content/public/common/permission_status.mojom b/content/public/common/permission_status.mojom

index f7e56bfab19cdbc096cb41eadab2dd099d3b097b..454f64618e2a2e40d7bb2db0ad68bc8d12d65e82 100644

--- a/content/public/common/permission_status.mojom

+++ b/content/public/common/permission_status.mojom

@@ -7,5 +7,6 @@ module content;

enum PermissionStatus {

GRANTED,

DENIED,

- ASK

+ ASK,

+ NUM

mlamouri (slow - plz ping) 2015/07/07 21:18:47 I'm confused but maybe I'm missing something. Why

keenanb 2015/07/08 00:37:21 UMA_HISTOGRAM_ENUMERATION needs a boundary value.

mlamouri (slow - plz ping) 2015/07/08 15:00:44 Can you do: LAST = ASK, instead of NUM. Then, yo

};