Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1197813002: Generate resource pak files for top chrome material design assets (Closed)

Created:
5 years, 6 months ago by tdanderson
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate resource pak files for top chrome material design assets Generate the pak files theme_resources_material_{100,200}_percent.pak which contain material design versions of the theme resources specified in theme_resources.grd. Note that these data packs do not fall back to non-material resources when the material resource is missing; as a result, the packs do not duplicate the resources contained within theme_resources_{100,200}_percent.pak. This CL also includes gypi and GN changes in order to repack into chrome_material_{100,200}_percent.pak, conditional on the ENABLE_TOPCHROME_MD compile-time flag. BUG=503754 TEST=none Committed: https://crrev.com/2a613d8e5e76e6e5c1612276bbc659c3a22cc118 Cr-Commit-Position: refs/heads/master@{#336661}

Patch Set 1 #

Patch Set 2 : WIP with GN #

Patch Set 3 : WIP #

Patch Set 4 : WIP #

Patch Set 5 : WIP #

Patch Set 6 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -0 lines) Patch
M chrome/BUILD.gn View 1 2 chunks +60 lines, -0 lines 0 comments Download
M chrome/app/theme/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/chrome_repack_chrome_material_100_percent.gypi View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/chrome_repack_chrome_material_200_percent.gypi View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
tdanderson
Hi Scott, can you please take a look? Note that addressing the trybot failures requires ...
5 years, 6 months ago (2015-06-25 23:59:08 UTC) #2
sky
Can you remind me why we need to support both resource types at the same ...
5 years, 5 months ago (2015-06-29 02:05:13 UTC) #3
tdanderson
On 2015/06/29 02:05:13, sky wrote: > Can you remind me why we need to support ...
5 years, 5 months ago (2015-06-29 16:32:18 UTC) #4
sky
Fair enough. I'm going to redirect to Brett as the gn expert. I've moved myself ...
5 years, 5 months ago (2015-06-29 20:12:34 UTC) #6
tdanderson
Note: removed [WIP] since the prerequisite grit change has been rolled in.
5 years, 5 months ago (2015-06-29 20:34:05 UTC) #8
brettw
lgtm
5 years, 5 months ago (2015-06-29 21:56:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197813002/100001
5 years, 5 months ago (2015-06-29 22:00:57 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 5 months ago (2015-06-29 22:30:37 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 22:31:42 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2a613d8e5e76e6e5c1612276bbc659c3a22cc118
Cr-Commit-Position: refs/heads/master@{#336661}

Powered by Google App Engine
This is Rietveld 408576698