Issue 119753009: Revert of Add onNewLockPixels, that returns rowbytes and relies on info in pixelref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119753009: Revert of Add onNewLockPixels, that returns rowbytes and relies on info in pixelref (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
hal.canary, scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -218 lines)			Patch
M	include/core/SkBitmapDevice.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/core/SkMallocPixelRef.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	include/core/SkPixelRef.h	View	5 chunks	+22 lines, -59 lines	0 comments	Download
M	include/gpu/SkGrPixelRef.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	include/images/SkImageRef.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+19 lines, -18 lines	0 comments	Download
M	src/core/SkMallocPixelRef.cpp	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	6 chunks	+24 lines, -55 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	4 chunks	+12 lines, -13 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View	1 chunk	+6 lines, -10 lines	0 comments	Download
M	src/images/SkImageRef.cpp	View	3 chunks	+7 lines, -10 lines	0 comments	Download
M	src/lazy/SkCachingPixelRef.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/lazy/SkCachingPixelRef.cpp	View	5 chunks	+8 lines, -11 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	2 chunks	+6 lines, -15 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of Add onNewLockPixels, that returns rowbytes and relies on info in pixelref

6 years, 11 months ago (2014-01-03 16:32:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/119753009/1

6 years, 11 months ago (2014-01-03 16:32:33 UTC) #2

Message was sent while issue was closed.

Change committed as 12884