Implement animations for Independent CSS Transform Properties

Implement animations for Independent CSS Transform Properties

Add AnimatableValues for Translate, Rotate and Scale using AnimatableTransform and
Interpolation for Translate and Scale.

This patch does not attempt to put their animations on the compositor. However,
extra code still needs to be added into KeyframeEffect so that compositor
animation on CSSPropertyTransform is cancelled when the independent properties
are added.

Design Doc :

https://docs.google.com/document/d/1Rbwj36VVhGuI7C3PQGuoEqJ2U9nAfzKXjwBV2N41JlQ/edit?usp=sharing

Link to Intent to implement:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/-GfE73tlLX8/hv7Qitys6j8J

Link to w3c specifications:

http://dev.w3.org/csswg/css-transforms-2/

BUG=496550
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197959

[soonm, 2015-06-23 04:34:19]

soonm@google.com changed reviewers:
+ alancutter@chromium.org, dstockwell@chromium.org, noel@chromium.org,
shans@chromium.org, timloh@chromium.org

[soonm, 2015-06-23 05:00:24]

soonm@google.com changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2015-06-23 06:27:53]

As translate can be specified in units like em, rem, etc., that can change
during the animation, it will be good to add a
LayoutTests/web-animations-api/animations-responsive-translate.html where the
font size changes during the animation.

Consider making transform-properties-interpolation.html 3 files. This makes
tests easier for people to find later when investigating a particular property.


In animations/interpolation,  We should also have an animation from 'inherit'
for each property:
e.g.
parent:
translate: 10px 10px

child: animates
from: 'inherit'
to: '20 px 0px'

means 
'10px 10px' to '20 px 0px'. 

(Again, the parent can change during the animation but there is no need to test
that.)

[Eric Willigers, 2015-06-23 06:50:48]

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Doubl...
File Source/core/animation/DoubleStyleInterpolation.cpp (right):

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Doubl...
Source/core/animation/DoubleStyleInterpolation.cpp:88:
PassOwnPtrWillBeRawPtr<InterpolableValue>
DoubleStyleInterpolation::toInterpolableValue(const CSSValue& value,
CSSPropertyID property)
I am not certain I understand how these DoubleStyleInterpolation changes relate
to the patch. Are these perhaps rebase artifacts, or does your patch rely on
DoubleStyleInterpolation changes?

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Keyfr...
File Source/core/animation/KeyframeEffect.cpp (right):

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Keyfr...
Source/core/animation/KeyframeEffect.cpp:263: }
Does KeyframeEffect::applyEffects() need the same test, to
cancelAnimationOnCompositor in the case a translate/rotate/scale/transform is
set after the composited animation has started?

If so, move the test into a new method.

https://codereview.chromium.org/1196913005/diff/1/Source/core/css/ComputedSty...
File Source/core/css/ComputedStyleCSSValueMapping.cpp (left):

https://codereview.chromium.org/1196913005/diff/1/Source/core/css/ComputedSty...
Source/core/css/ComputedStyleCSSValueMapping.cpp:959: 
There is no need to touch this file.

https://codereview.chromium.org/1196913005/diff/1/Source/core/style/ComputedS...
File Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/1196913005/diff/1/Source/core/style/ComputedS...
Source/core/style/ComputedStyle.cpp:925: 
No need to touch this file.

[soonm, 2015-06-24 00:26:45]

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Doubl...
File Source/core/animation/DoubleStyleInterpolation.cpp (right):

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Doubl...
Source/core/animation/DoubleStyleInterpolation.cpp:88:
PassOwnPtrWillBeRawPtr<InterpolableValue>
DoubleStyleInterpolation::toInterpolableValue(const CSSValue& value,
CSSPropertyID property)
On 2015/06/23 at 06:50:48, Eric Willigers wrote:
> I am not certain I understand how these DoubleStyleInterpolation changes
relate to the patch. Are these perhaps rebase artifacts, or does your patch rely
on DoubleStyleInterpolation changes?

I added these interface to make ListStyleInterpolation<DoubleStyleInterpolation>
in StringKeyframe work.

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Keyfr...
File Source/core/animation/KeyframeEffect.cpp (right):

https://codereview.chromium.org/1196913005/diff/1/Source/core/animation/Keyfr...
Source/core/animation/KeyframeEffect.cpp:263: }
On 2015/06/23 at 06:50:48, Eric Willigers wrote:
> Does KeyframeEffect::applyEffects() need the same test, to
cancelAnimationOnCompositor in the case a translate/rotate/scale/transform is
set after the composited animation has started?
> 
> If so, move the test into a new method.

Will move into new methods in a new patch with compositor animations

https://codereview.chromium.org/1196913005/diff/1/Source/core/css/ComputedSty...
File Source/core/css/ComputedStyleCSSValueMapping.cpp (left):

https://codereview.chromium.org/1196913005/diff/1/Source/core/css/ComputedSty...
Source/core/css/ComputedStyleCSSValueMapping.cpp:959: 
On 2015/06/23 at 06:50:48, Eric Willigers wrote:
> There is no need to touch this file.

Done - Reverted

https://codereview.chromium.org/1196913005/diff/1/Source/core/style/ComputedS...
File Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/1196913005/diff/1/Source/core/style/ComputedS...
Source/core/style/ComputedStyle.cpp:925: 
On 2015/06/23 at 06:50:48, Eric Willigers wrote:
> No need to touch this file.

Done - Reverted

[Timothy Loh, 2015-06-24 01:00:28]

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
File Source/core/animation/DoubleStyleInterpolation.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:37: value =
clampTo<float>(value, 0, 1);
Probably looks better if you just return in the individual cases

https://codereview.chromium.org/1196913005/diff/20001/Source/core/style/Compu...
File Source/core/style/ComputedStyle.h (left):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/style/Compu...
Source/core/style/ComputedStyle.h:1351: 
better to not touch random lines :/

[alancutter (OOO until 2018), 2015-06-24 01:17:10]

https://codereview.chromium.org/1196913005/diff/20001/LayoutTests/animations/...
File LayoutTests/animations/interpolation/rotate-interpolation.html (right):

https://codereview.chromium.org/1196913005/diff/20001/LayoutTests/animations/...
LayoutTests/animations/interpolation/rotate-interpolation.html:104: to: '0deg'
Trailing comma for consistency.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
File Source/core/animation/DoubleStyleInterpolation.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:60: return value;
Push this return up into the case statements.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:96: // TODO Get the correct
angle or double unit type
There's not enough context in the code to justify this TODO, I'd leave it out.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/K...
File Source/core/animation/KeyframeEffect.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/K...
Source/core/animation/KeyframeEffect.cpp:139: // Cancel composited animation of
transform if a motion path has been introduced on the element.
Update comment.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/S...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: fallBackToLegacy = true;
I suspect you don't need this, see if your tests still pass without it. If not
then add a TODO that states which values require us to fall back to legacy.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/c...
File Source/core/animation/css/CSSAnimatableValueFactory.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/c...
Source/core/animation/css/CSSAnimatableValueFactory.cpp:268: }
This could use a ternary.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/style/Compu...
File Source/core/style/ComputedStyle.h (left):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/style/Compu...
Source/core/style/ComputedStyle.h:1819: bool hasTransformOperations() const {
return !rareNonInheritedData->m_transform->m_operations.operations().isEmpty();
}
Does this file need to change?

https://codereview.chromium.org/1196913005/diff/20001/Source/platform/transfo...
File Source/platform/transforms/TransformOperation.h (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:110: }
Make these virtual and define them in the subclasses. Update their constructor's
assertion to use this to avoid duplication of these type lists.

[soonm, 2015-06-24 02:53:20]

https://codereview.chromium.org/1196913005/diff/20001/LayoutTests/animations/...
File LayoutTests/animations/interpolation/rotate-interpolation.html (right):

https://codereview.chromium.org/1196913005/diff/20001/LayoutTests/animations/...
LayoutTests/animations/interpolation/rotate-interpolation.html:104: to: '0deg'
On 2015/06/24 at 01:17:09, alancutter wrote:
> Trailing comma for consistency.

Done - added comma

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
File Source/core/animation/DoubleStyleInterpolation.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:37: value =
clampTo<float>(value, 0, 1);
On 2015/06/24 at 01:00:28, Timothy Loh wrote:
> Probably looks better if you just return in the individual cases

Done.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:60: return value;
On 2015/06/24 at 01:17:09, alancutter wrote:
> Push this return up into the case statements.

Done.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:96: // TODO Get the correct
angle or double unit type
On 2015/06/24 at 01:17:09, alancutter wrote:
> There's not enough context in the code to justify this TODO, I'd leave it out.

Done - Removed

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/K...
File Source/core/animation/KeyframeEffect.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/K...
Source/core/animation/KeyframeEffect.cpp:139: // Cancel composited animation of
transform if a motion path has been introduced on the element.
On 2015/06/24 at 01:17:09, alancutter wrote:
> Update comment.

Done

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/S...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: fallBackToLegacy = true;
On 2015/06/24 at 01:17:09, alancutter wrote:
> I suspect you don't need this, see if your tests still pass without it. If not
then add a TODO that states which values require us to fall back to legacy.

I still need this when the lists are different lengths. This usually happens
when either 'from' or 'to' does not have a defined value, so the list is empty.
Practically, I could put fill up the different axes with default values.

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/c...
File Source/core/animation/css/CSSAnimatableValueFactory.cpp (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/core/animation/c...
Source/core/animation/css/CSSAnimatableValueFactory.cpp:268: }
On 2015/06/24 at 01:17:09, alancutter wrote:
> This could use a ternary.

Done - Changed to use ternary operation

https://codereview.chromium.org/1196913005/diff/20001/Source/platform/transfo...
File Source/platform/transforms/TransformOperation.h (right):

https://codereview.chromium.org/1196913005/diff/20001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:110: }
On 2015/06/24 at 01:17:09, alancutter wrote:
> Make these virtual and define them in the subclasses. Update their
constructor's assertion to use this to avoid duplication of these type lists.

Done.

[Eric Willigers, 2015-06-24 03:43:08]

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: fallBackToLegacy = true;
Do we need this line? Same for Scale. I suspect we only need fall back for
'inherit' etc., and that case is already covered by "if
(fromCSSValue->isCSSWideKeyword() || toCSSValue->isCSSWideKeyword())" further
down.

https://codereview.chromium.org/1196913005/diff/40001/Source/core/css/resolve...
File Source/core/css/resolver/AnimatedStyleBuilder.cpp (right):

https://codereview.chromium.org/1196913005/diff/40001/Source/core/css/resolve...
Source/core/css/resolver/AnimatedStyleBuilder.cpp:608: const
TransformOperations& transformList =
toAnimatableTransform(value)->transformOperations();
The repetition here is unfortunate. Perhaps consider introducing a new anonymous
namespace method that accepts value and an operation type, and returns a
TransformOperation* (or TransformOperation&).

[soonm, 2015-06-24 05:00:45]

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: fallBackToLegacy = true;
On 2015/06/24 at 03:43:08, Eric Willigers wrote:
> Do we need this line? Same for Scale. I suspect we only need fall back for
'inherit' etc., and that case is already covered by "if
(fromCSSValue->isCSSWideKeyword() || toCSSValue->isCSSWideKeyword())" further
down.

ListStyleInterpolation does not handle the case where the length of
'fromCSSValue' is different from 'toCSSValue' value list.

So I could insert default values into the list when they are different length.
Checking with Alan if that's ok.

https://codereview.chromium.org/1196913005/diff/40001/Source/core/css/resolve...
File Source/core/css/resolver/AnimatedStyleBuilder.cpp (right):

https://codereview.chromium.org/1196913005/diff/40001/Source/core/css/resolve...
Source/core/css/resolver/AnimatedStyleBuilder.cpp:608: const
TransformOperations& transformList =
toAnimatableTransform(value)->transformOperations();
On 2015/06/24 at 03:43:08, Eric Willigers wrote:
> The repetition here is unfortunate. Perhaps consider introducing a new
anonymous namespace method that accepts value and an operation type, and returns
a TransformOperation* (or TransformOperation&).

Done - abstracted to a new method in anonymous namespace

[alancutter (OOO until 2018), 2015-06-25 01:33:10]

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: fallBackToLegacy = true;
On 2015/06/24 at 05:00:44, soonm wrote:
> On 2015/06/24 at 03:43:08, Eric Willigers wrote:
> > Do we need this line? Same for Scale. I suspect we only need fall back for
'inherit' etc., and that case is already covered by "if
(fromCSSValue->isCSSWideKeyword() || toCSSValue->isCSSWideKeyword())" further
down.
> 
> ListStyleInterpolation does not handle the case where the length of
'fromCSSValue' is different from 'toCSSValue' value list.
> 
> So I could insert default values into the list when they are different length.
Checking with Alan if that's ok.

Add TODO for this for now just so it's clear what's not supported by this code
path. I don't think we should be making major changes to the current
Interpolation code other than migrating away from it.

https://codereview.chromium.org/1196913005/diff/60001/Source/core/animation/D...
File Source/core/animation/DoubleStyleInterpolation.cpp (right):

https://codereview.chromium.org/1196913005/diff/60001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:51: ASSERT_NOT_REACHED();
You still need a return value here.

https://codereview.chromium.org/1196913005/diff/60001/Source/core/animation/D...
Source/core/animation/DoubleStyleInterpolation.cpp:89: return
CSSPrimitiveValue::create(doubleValue, CSSPrimitiveValue::CSS_NUMBER);
This can just call interpolableValueToDouble().

https://codereview.chromium.org/1196913005/diff/60001/Source/platform/transfo...
File Source/platform/transforms/TransformOperation.h (right):

https://codereview.chromium.org/1196913005/diff/60001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:84: virtual bool
isMatchingOperationType() const { return false; }
This should actually be a static method on the subtypes that takes an
OperationType otherwise the cast isn't checking anything.

https://codereview.chromium.org/1196913005/diff/60001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:88: #define
DEFINE_TRANSFORM_TYPE_CASTS(thisType, predicate) \
This doesn't need to take a predicate as it will be the same for all subtypes.

[soonm, 2015-06-26 02:52:34]

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: fallBackToLegacy = true;
On 2015/06/25 at 01:33:09, alancutter wrote:
> On 2015/06/24 at 05:00:44, soonm wrote:
> > On 2015/06/24 at 03:43:08, Eric Willigers wrote:
> > > Do we need this line? Same for Scale. I suspect we only need fall back for
'inherit' etc., and that case is already covered by "if
(fromCSSValue->isCSSWideKeyword() || toCSSValue->isCSSWideKeyword())" further
down.
> > 
> > ListStyleInterpolation does not handle the case where the length of
'fromCSSValue' is different from 'toCSSValue' value list.
> > 
> > So I could insert default values into the list when they are different
length. Checking with Alan if that's ok.
> 
> Add TODO for this for now just so it's clear what's not supported by this code
path. I don't think we should be making major changes to the current
Interpolation code other than migrating away from it.

Done - Add TODO about legacy mode when list are different lengths.

https://codereview.chromium.org/1196913005/diff/40001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: fallBackToLegacy = true;
On 2015/06/25 at 01:33:09, alancutter wrote:
> On 2015/06/24 at 05:00:44, soonm wrote:
> > On 2015/06/24 at 03:43:08, Eric Willigers wrote:
> > > Do we need this line? Same for Scale. I suspect we only need fall back for
'inherit' etc., and that case is already covered by "if
(fromCSSValue->isCSSWideKeyword() || toCSSValue->isCSSWideKeyword())" further
down.
> > 
> > ListStyleInterpolation does not handle the case where the length of
'fromCSSValue' is different from 'toCSSValue' value list.
> > 
> > So I could insert default values into the list when they are different
length. Checking with Alan if that's ok.
> 
> Add TODO for this for now just so it's clear what's not supported by this code
path. I don't think we should be making major changes to the current
Interpolation code other than migrating away from it.

Done - Add TODO about legacy mode when list are different lengths.

https://codereview.chromium.org/1196913005/diff/60001/Source/platform/transfo...
File Source/platform/transforms/TransformOperation.h (right):

https://codereview.chromium.org/1196913005/diff/60001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:84: virtual bool
isMatchingOperationType() const { return false; }
On 2015/06/25 at 01:33:10, alancutter wrote:
> This should actually be a static method on the subtypes that takes an
OperationType otherwise the cast isn't checking anything.

Yep I see why it doesn't check anything now. Done.

https://codereview.chromium.org/1196913005/diff/60001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:88: #define
DEFINE_TRANSFORM_TYPE_CASTS(thisType, predicate) \
On 2015/06/25 at 01:33:09, alancutter wrote:
> This doesn't need to take a predicate as it will be the same for all subtypes.

Done.

[alancutter (OOO until 2018), 2015-06-26 02:56:16]

lgtm with nits.

https://codereview.chromium.org/1196913005/diff/80001/Source/core/animation/S...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1196913005/diff/80001/Source/core/animation/S...
Source/core/animation/StringKeyframe.cpp:410: // TODO: Legacy mode is used when
from and to cssvaluelist length does not match.
It's Blink style to add your username to any TODOs you add.

https://codereview.chromium.org/1196913005/diff/80001/Source/platform/transfo...
File Source/platform/transforms/TransformOperation.h (right):

https://codereview.chromium.org/1196913005/diff/80001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:84: 
No need for extra newline.

[soonm, 2015-06-26 03:02:12]

https://codereview.chromium.org/1196913005/diff/80001/Source/platform/transfo...
File Source/platform/transforms/TransformOperation.h (right):

https://codereview.chromium.org/1196913005/diff/80001/Source/platform/transfo...
Source/platform/transforms/TransformOperation.h:84: 
On 2015/06/26 at 02:56:15, alancutter wrote:
> No need for extra newline.

Done.

[Eric Willigers, 2015-06-29 01:15:08]

lgtm

[soonm, 2015-06-29 01:17:34]

The CQ bit was checked by soonm@google.com

[soonm, 2015-06-29 01:17:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1196913005/#ps120001
(title: "Add test for responsive font and rebase master")

[commit-bot: I haz the power, 2015-06-29 01:17:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196913005/120001

[soonm, 2015-06-29 01:17:45]

The CQ bit was unchecked by soonm@google.com

[soonm, 2015-06-29 01:32:41]

The CQ bit was checked by soonm@google.com

[soonm, 2015-06-29 01:32:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1196913005/#ps140001
(title: "New blink checkout")

[commit-bot: I haz the power, 2015-06-29 01:32:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196913005/140001

[commit-bot: I haz the power, 2015-06-29 01:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 01:38:06]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[Timothy Loh, 2015-06-29 01:49:17]

On 2015/06/29 01:38:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   blink_presubmit on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

core/ stampy stamp lgtm

[Noel Gordon, 2015-06-29 01:58:50]

platform/ lgtm.

[soonm, 2015-06-29 02:00:04]

The CQ bit was checked by soonm@google.com

[commit-bot: I haz the power, 2015-06-29 02:00:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196913005/140001

[commit-bot: I haz the power, 2015-06-29 02:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 02:29:34]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Noel Gordon, 2015-06-29 02:55:23]

animations/interpolation/rotate-interpolation.html is failing on the trys.

[soonm, 2015-06-29 03:58:52]

The CQ bit was checked by soonm@google.com

[soonm, 2015-06-29 03:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, timloh@chromium.org, ericwilligers@chromium.org,
noel@chromium.org
Link to the patchset: https://codereview.chromium.org/1196913005/#ps160001
(title: "Fix rotate-interpolation test")

[commit-bot: I haz the power, 2015-06-29 03:59:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196913005/160001

[commit-bot: I haz the power, 2015-06-29 05:05:40]

Committed patchset #9 (id:160001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197959