Implement animations for Independent CSS Transform Properties

Source/core/animation/StringKeyframe.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/StringKeyframe.h"
 
 #include "core/animation/AngleSVGInterpolation.h"
 #include "core/animation/ColorStyleInterpolation.h"
 #include "core/animation/CompositorAnimations.h"
@@ skipping 384 matching lines @@
     case CSSPropertyWebkitFilter: {
         RefPtrWillBeRawPtr<Interpolation> interpolation = FilterStyleInterpolation::maybeCreateList(*fromCSSValue, *toCSSValue, property);
         if (interpolation)
             return interpolation.release();
 
         // FIXME: Support drop shadow interpolation.
         fallBackToLegacy = true;
         break;
     }
 
+    case CSSPropertyTranslate: {
+        RefPtrWillBeRawPtr<Interpolation> interpolation = ListStyleInterpolation<LengthStyleInterpolation>::maybeCreateFromList(*fromCSSValue, *toCSSValue, property, range);
+        if (interpolation)
+            return interpolation.release();
+
+        fallBackToLegacy = true;

[Eric Willigers, 2015/06/24 03:43:08]

Do we need this line? Same for Scale. I suspect we only need fall back for
'inherit' etc., and that case is already covered by "if
(fromCSSValue->isCSSWideKeyword() || toCSSValue->isCSSWideKeyword())" further
down.

[soonm, 2015/06/24 05:00:44]

ListStyleInterpolation does not handle the case where the length of
'fromCSSValue' is different from 'toCSSValue' value list.

So I could insert default values into the list when they are different length.
Checking with Alan if that's ok.

[alancutter (OOO until 2018), 2015/06/25 01:33:09]

Add TODO for this for now just so it's clear what's not supported by this code
path. I don't think we should be making major changes to the current
Interpolation code other than migrating away from it.

[soonm, 2015/06/26 02:52:34]

Done - Add TODO about legacy mode when list are different lengths.

[soonm, 2015/06/26 02:52:34]

Done - Add TODO about legacy mode when list are different lengths.

+        break;
+    }
+
+    case CSSPropertyScale: {
+        RefPtrWillBeRawPtr<Interpolation> interpolation = ListStyleInterpolation<DoubleStyleInterpolation>::maybeCreateFromList(*fromCSSValue, *toCSSValue, property, range);
+        if (interpolation)
+            return interpolation.release();
+
+        fallBackToLegacy = true;
+        break;
+    }
+
     default:
         // Fall back to LegacyStyleInterpolation.
         fallBackToLegacy = true;
         break;
     }
 
     if (fromCSSValue == toCSSValue)
         return ConstantStyleInterpolation::create(fromCSSValue, property);
 
     if (forceDefaultInterpolation)
@@ skipping 134 matching lines @@
     RefPtrWillBeRawPtr<SVGPropertyBase> fromValue = attribute->currentValueBase()->cloneForAnimation(m_value);
     RefPtrWillBeRawPtr<SVGPropertyBase> toValue = attribute->currentValueBase()->cloneForAnimation(toSVGPropertySpecificKeyframe(end).value());
 
     if (!fromValue || !toValue)
         return nullptr;
 
     return createSVGInterpolation(fromValue.get(), toValue.get(), attribute.get());
 }
 
 } // namespace blink