Implement animations for Independent CSS Transform Properties

Source/core/css/resolver/AnimatedStyleBuilder.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 579 matching lines @@
     case CSSPropertyWebkitTextStrokeColor:
         style->setTextStrokeColor(toAnimatableColor(value)->color());
         style->setVisitedLinkTextStrokeColor(toAnimatableColor(value)->visitedLinkColor());
         return;
     case CSSPropertyTransform: {
         const TransformOperations& operations = toAnimatableTransform(value)->transformOperations();
         // FIXME: This normalization (handling of 'none') should be performed at input in AnimatableValueFactory.
         style->setTransform(operations.size() ? operations : TransformOperations(true));
         return;
     }
+    case CSSPropertyTranslate: {
+        const TransformOperations& transformList = toAnimatableTransform(value)->transformOperations();
+        ASSERT(transformList.size() == 1);
+        ASSERT(transformList.operations()[0]->type() == TransformOperation::Translate3D);
+        style->setTranslate(toTranslateTransformOperation(transformList.operations()[0].get()));
+        return;
+    }
+    case CSSPropertyRotate: {
+        const TransformOperations& transformList = toAnimatableTransform(value)->transformOperations();

[Eric Willigers, 2015/06/24 03:43:08]

The repetition here is unfortunate. Perhaps consider introducing a new anonymous
namespace method that accepts value and an operation type, and returns a
TransformOperation* (or TransformOperation&).

[soonm, 2015/06/24 05:00:44]

Done - abstracted to a new method in anonymous namespace

+        ASSERT(transformList.size() == 1);
+        ASSERT(transformList.operations()[0]->type() == TransformOperation::Rotate3D);
+        style->setRotate(toRotateTransformOperation(transformList.operations()[0].get()));
+        return;
+    }
+    case CSSPropertyScale: {
+        const TransformOperations& transformList = toAnimatableTransform(value)->transformOperations();
+        ASSERT(transformList.size() == 1);
+        ASSERT(transformList.operations()[0]->type() == TransformOperation::Scale3D);
+        style->setScale(toScaleTransformOperation(transformList.operations()[0].get()));
+        return;
+    }
     case CSSPropertyTransformOrigin:
         style->setTransformOrigin(animatableValueToTransformOrigin(value, state));
         return;
     case CSSPropertyMotionOffset:
         style->setMotionOffset(animatableValueToLength(value, state));
         return;
     case CSSPropertyMotionRotation:
         style->setMotionRotation(toAnimatableDoubleAndBool(value)->toDouble());
         style->setMotionRotationType(toAnimatableDoubleAndBool(value)->flag() ? MotionRotationAuto : MotionRotationFixed);
         return;
@@ skipping 51 matching lines @@
     case CSSPropertyRy:
         style->setRy(animatableValueToLength(value, state, ValueRangeNonNegative));
         return;
 
     default:
         ASSERT_NOT_REACHED();
     }
 }
 
 } // namespace blink