Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11967033: [CLOSED] In-browser software compositing (Closed)

Created:
7 years, 11 months ago by slavi
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

In-browser software compositing implemented for windows and linux. The in-browser software compositing mode is behind the switch --ui-enable-software-compositing BUG=161008, 171055

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Removed some duplicated code. #

Patch Set 4 : Some more duplicated code removed. #

Patch Set 5 : Some more code removal. #

Patch Set 6 : . #

Patch Set 7 : #

Patch Set 8 : Linux support for UI software compositing. #

Patch Set 9 : Rebase #

Patch Set 10 : Fixed unit tests. #

Patch Set 11 : Added windows support #

Patch Set 12 : Rebased. #

Patch Set 13 : Fix the lack SkCanvas::clear scissoring. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+584 lines, -566 lines) Patch
M cc/cc.gyp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
A cc/output_surface_impl.h View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
A cc/output_surface_impl.cc View 1 2 3 4 5 6 7 1 chunk +60 lines, -0 lines 0 comments Download
M cc/software_output_device.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +15 lines, -9 lines 0 comments Download
A cc/software_output_device_impl.h View 1 2 3 4 5 6 7 1 chunk +42 lines, -0 lines 0 comments Download
A cc/software_output_device_impl.cc View 1 2 3 4 5 6 7 1 chunk +51 lines, -0 lines 0 comments Download
M cc/software_renderer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/software_renderer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +14 lines, -12 lines 0 comments Download
M cc/software_renderer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +8 lines, -10 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M cc/test/fake_output_surface.h View 1 2 3 3 chunks +20 lines, -34 lines 0 comments Download
M cc/test/fake_output_surface.cc View 1 2 3 1 chunk +4 lines, -27 lines 0 comments Download
M cc/test/fake_software_output_device.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
M cc/test/fake_software_output_device.cc View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
M content/browser/renderer_host/backing_store_win.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +11 lines, -34 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 1 2 3 4 5 6 7 4 chunks +17 lines, -3 lines 0 comments Download
A content/browser/renderer_host/software_output_device.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +49 lines, -0 lines 0 comments Download
A content/browser/renderer_host/software_output_device_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +71 lines, -0 lines 0 comments Download
A content/browser/renderer_host/software_output_device_win.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +43 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 1 2 3 4 3 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 2 3 4 3 chunks +8 lines, -12 lines 0 comments Download
D content/renderer/gpu/compositor_software_output_device_gl_adapter.h View 1 2 3 4 5 6 7 1 chunk +15 lines, -29 lines 0 comments Download
D content/renderer/gpu/compositor_software_output_device_gl_adapter.cc View 1 2 3 4 5 6 7 2 chunks +42 lines, -82 lines 0 comments Download
M ui/base/x/x11_util.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 5 6 7 5 chunks +10 lines, -48 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor_switches.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/gdi_util.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/gdi_util.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +24 lines, -1 line 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/compositor_bindings/web_compositor_support_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +7 lines, -8 lines 0 comments Download
M webkit/compositor_bindings/web_compositor_support_output_surface.h View 2 3 1 chunk +0 lines, -54 lines 0 comments Download
M webkit/compositor_bindings/web_compositor_support_output_surface.cc View 2 3 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/compositor_bindings/web_compositor_support_software_output_device.h View 2 1 chunk +0 lines, -35 lines 0 comments Download
D webkit/compositor_bindings/web_compositor_support_software_output_device.cc View 2 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
slavi
Most of the changes are removing duplicated code. The interesting parts are in content/browser/renderer_host/software_output_device_* The ...
7 years, 11 months ago (2013-01-23 02:41:48 UTC) #1
piman
This patch is pretty big - note also that you need a lot of OWNERs ...
7 years, 11 months ago (2013-01-23 22:32:32 UTC) #2
Leandro Graciá Gil
Is there any work going on on this? Perhaps some subpatches being reviewed?
7 years, 10 months ago (2013-02-20 18:41:34 UTC) #3
slavi
7 years, 9 months ago (2013-03-10 20:44:14 UTC) #4 
On 2013/02/20 18:41:34, Leandro Graciá Gil wrote:
> Is there any work going on on this? Perhaps some subpatches being reviewed?

Yes, I actively working on this. Parts of it are already landed:
https://codereview.chromium.org/12379055/
https://codereview.chromium.org/12542006/

Powered by Google App Engine
This is Rietveld 408576698