[Android] Sever findbugs dependencies on environment variables.

[Android] Sever findbugs dependencies on environment variables.

Use pylib constants instead.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177208

[frankf, 2013-01-16 18:10:46]

Drive-by.

https://codereview.chromium.org/11967019/diff/1/build/android/findbugs_diff.py
File build/android/findbugs_diff.py (left):

https://codereview.chromium.org/11967019/diff/1/build/android/findbugs_diff.p...
build/android/findbugs_diff.py:31: from pylib import findbugs
while you're here, move findbugs to pylib/utils?

https://codereview.chromium.org/11967019/diff/1/build/android/pylib/findbugs.py
File build/android/pylib/findbugs.py (right):

https://codereview.chromium.org/11967019/diff/1/build/android/pylib/findbugs....
build/android/pylib/findbugs.py:14: from pylib import constants
2 blank lines below this.

[Yaron, 2013-01-16 18:15:28]

https://codereview.chromium.org/11967019/diff/1/build/android/findbugs_diff.py
File build/android/findbugs_diff.py (left):

https://codereview.chromium.org/11967019/diff/1/build/android/findbugs_diff.p...
build/android/findbugs_diff.py:31: from pylib import findbugs
On 2013/01/16 18:10:46, frankf wrote:
> while you're here, move findbugs to pylib/utils?

How do you decide what goes in utils?

https://codereview.chromium.org/11967019/diff/1/build/android/pylib/findbugs.py
File build/android/pylib/findbugs.py (right):

https://codereview.chromium.org/11967019/diff/1/build/android/pylib/findbugs....
build/android/pylib/findbugs.py:14: from pylib import constants
On 2013/01/16 18:10:46, frankf wrote:
> 2 blank lines below this.

Done.

[frankf, 2013-01-16 18:20:36]

Eventually, we won't have anything in the top-level package. Tentative plan is
to have a 'device' package for device handling stuff (see issue 170210).
Everything else (i.e. host utils) should go in utils.

On 2013/01/16 18:15:28, Yaron wrote:
> https://codereview.chromium.org/11967019/diff/1/build/android/findbugs_diff.py
> File build/android/findbugs_diff.py (left):
> 
>
https://codereview.chromium.org/11967019/diff/1/build/android/findbugs_diff.p...
> build/android/findbugs_diff.py:31: from pylib import findbugs
> On 2013/01/16 18:10:46, frankf wrote:
> > while you're here, move findbugs to pylib/utils?
> 
> How do you decide what goes in utils?
> 
>
https://codereview.chromium.org/11967019/diff/1/build/android/pylib/findbugs.py
> File build/android/pylib/findbugs.py (right):
> 
>
https://codereview.chromium.org/11967019/diff/1/build/android/pylib/findbugs....
> build/android/pylib/findbugs.py:14: from pylib import constants
> On 2013/01/16 18:10:46, frankf wrote:
> > 2 blank lines below this.
> 
> Done.

[Yaron, 2013-01-16 19:15:19]

moved

[frankf, 2013-01-16 19:22:22]

lgtm

https://codereview.chromium.org/11967019/diff/10006/tools/android/findbugs_pl...
File tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py (right):

https://codereview.chromium.org/11967019/diff/10006/tools/android/findbugs_pl...
tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py:21: lib_folder =
os.path.join(os.getenv('CHROME_SRC'), 'build', 'android')
Nit: Use pylib constants here too.

[Yaron, 2013-01-16 20:30:53]

Thanks for the review. Landing

https://codereview.chromium.org/11967019/diff/10006/tools/android/findbugs_pl...
File tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py (right):

https://codereview.chromium.org/11967019/diff/10006/tools/android/findbugs_pl...
tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py:21: lib_folder =
os.path.join(os.getenv('CHROME_SRC'), 'build', 'android')
On 2013/01/16 19:22:23, frankf wrote:
> Nit: Use pylib constants here too.

I can't because we're using this to get the path to pylib. Changed to using
offset from __file__ and changed the lower usage to constants.